From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: linux-trace-devel@vger.kernel.org
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 1/4] trace-cruncher: Use proper naming in common.h
Date: Tue, 17 Aug 2021 19:41:07 +0300 [thread overview]
Message-ID: <20210817164110.152016-1-y.karadz@gmail.com> (raw)
PyTepEvent was the first Python type defined in the C extension module.
A legacy from this first implementation can be found in the naming of
some variables used by the type definition macros.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
src/common.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/common.h b/src/common.h
index 9985328..6046c0f 100644
--- a/src/common.h
+++ b/src/common.h
@@ -54,27 +54,27 @@ static inline void no_free()
#define STR(x) #x
-#define MAKE_TYPE_STR(x) STR(traceevent.x)
+#define MAKE_TYPE_STR(x) STR(trace.x)
-#define MAKE_DIC_STR(x) STR(libtraceevent x object)
+#define MAKE_DIC_STR(x) STR(libtrace x object)
#define C_OBJECT_WRAPPER_DECLARE(c_type, py_type) \
typedef struct { \
PyObject_HEAD \
struct c_type *ptrObj; \
} py_type; \
-PyObject *py_type##_New(struct c_type *evt_ptr); \
+PyObject *py_type##_New(struct c_type *c_ptr); \
bool py_type##TypeInit(); \
#define C_OBJECT_WRAPPER(c_type, py_type, ptr_free) \
static PyTypeObject py_type##Type = { \
PyVarObject_HEAD_INIT(NULL, 0) MAKE_TYPE_STR(c_type) \
}; \
-PyObject *py_type##_New(struct c_type *evt_ptr) \
+PyObject *py_type##_New(struct c_type *c_ptr) \
{ \
py_type *newObject; \
newObject = PyObject_New(py_type, &py_type##Type); \
- newObject->ptrObj = evt_ptr; \
+ newObject->ptrObj = c_ptr; \
return (PyObject *) newObject; \
} \
static int py_type##_init(py_type *self, PyObject *args, PyObject *kwargs) \
--
2.30.2
next reply other threads:[~2021-08-17 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 16:41 Yordan Karadzhov (VMware) [this message]
2021-08-17 16:41 ` [PATCH 2/4] trace-cruncher: Add type checking for the custom Python types Yordan Karadzhov (VMware)
2021-08-17 16:41 ` [PATCH 3/4] trace-cruncher: Define Python type for instances Yordan Karadzhov (VMware)
2021-08-17 16:41 ` [PATCH 4/4] trace-cruncher: Refactor the way libtracefs instances are handled Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817164110.152016-1-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).