From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v6 4/5] libtraceevent: Optimize tep_print_fields()
Date: Thu, 19 Aug 2021 12:49:29 -0400 [thread overview]
Message-ID: <20210819124929.741d6453@oasis.local.home> (raw)
In-Reply-To: <20210812085929.54832-5-y.karadz@gmail.com>
On Thu, 12 Aug 2021 11:59:28 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> -void tep_print_field(struct trace_seq *s, void *data,
> - struct tep_format_field *field)
> +void static inline _tep_print_field(struct trace_seq *s, void *data,
> + struct tep_format_field *field,
> + struct tep_print_parse **parse_ptr)
Same here. We should call this simply "print_field()".
-- Steve
> {
> struct tep_event *event = field->event;
> + struct tep_print_parse *start_parse;
> struct tep_print_parse *parse;
> bool has_0x;
next prev parent reply other threads:[~2021-08-19 16:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 8:59 [PATCH v6 0/5] libtraceevent: Optimize the print of tep fields Yordan Karadzhov (VMware)
2021-08-12 8:59 ` [PATCH v6 1/5] libtraceevent: Add dynamic_offset() Yordan Karadzhov (VMware)
2021-08-12 8:59 ` [PATCH v6 2/5] libtraceevent: Have all field args point to the field they represent Yordan Karadzhov (VMware)
2021-08-12 8:59 ` [PATCH v6 3/5] libtraceevent: Improve tep_print_field() Yordan Karadzhov (VMware)
2021-08-19 16:48 ` Steven Rostedt
2021-08-12 8:59 ` [PATCH v6 4/5] libtraceevent: Optimize tep_print_fields() Yordan Karadzhov (VMware)
2021-08-19 16:49 ` Steven Rostedt [this message]
2021-08-12 8:59 ` [PATCH v6 5/5] libtraceevent: Add tep_print_selected_fields() Yordan Karadzhov (VMware)
2021-08-19 16:55 ` Steven Rostedt
2021-08-20 13:36 ` Yordan Karadzhov
2021-08-20 14:35 ` Steven Rostedt
2021-08-20 15:05 ` Yordan Karadzhov
2021-08-20 16:01 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819124929.741d6453@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).