Re: [PATCH v2] trace-cmd: Add dependencies to BUILDING section in README

[Steven Rostedt <rostedt@goodmis.org>]

On Fri, 13 Aug 2021 16:25:16 -0300
victorcora98@gmail.com wrote:

> From: Victor Cora Colombo <victorcora98@gmail.com>

I finally got some time to look at this.

> 
> KernelShark has instructions in its README on how to get necessary
> dependencies to build it. trace-cmd could follow this example and
> also add more information on how to build it.
> 
> This patch adds instructions to README on how to get necessary libraries
> and dependencies to build trace-cmd.
> 
> Signed-off-by: Victor Cora Colombo <victorcora98@gmail.com>
> ---
>  README | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/README b/README
> index 1153152..094fce1 100644
> --- a/README
> +++ b/README
> @@ -24,6 +24,23 @@ Lesser General Public License 2.1 (See COPYING.LIB).
>  
>  BUILDING:
>  
> +In order to install build dependencies on Ubuntu do the following:
> +    sudo apt-get install build-essential git pkg-config -y
> +
> +In order to install build dependencies on Fedora, as root do the following:
> +    dnf install gcc make git pkg-config -y

I would actually add above libtracefs-devel and libtraceevent-devel for
fedora, and possibly libtracefs-dev and libtraceevent-dev for ubuntu /
debian. Oh, I would say that too, as I don't use Ubuntu thus, state "on
Debian / Ubuntu do the following".


> +
> +To install required dependencies:

Then you can say here.

In case the distribution does not have the required libtracefs and
libtraceevent libraries, install them manually:

Or something to that nature.

-- Steve


> +    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
> +    cd libtraceevent
> +    make
> +    sudo make install
> +
> +    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
> +    cd libtracefs
> +    make
> +    sudo make install
> +
>  To make trace-cmd
>      make
>