From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C85C4338F for ; Thu, 19 Aug 2021 19:54:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDB51610CF for ; Thu, 19 Aug 2021 19:54:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234640AbhHSTyu (ORCPT ); Thu, 19 Aug 2021 15:54:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:35104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235080AbhHSTyu (ORCPT ); Thu, 19 Aug 2021 15:54:50 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 903AC61051; Thu, 19 Aug 2021 19:54:13 +0000 (UTC) Date: Thu, 19 Aug 2021 15:54:12 -0400 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v2 0/7] trace-cruncher: Refactor instances and kprobes Message-ID: <20210819155412.0a6fe8bf@oasis.local.home> In-Reply-To: <20210819130827.12327-1-y.karadz@gmail.com> References: <20210819130827.12327-1-y.karadz@gmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 19 Aug 2021 16:08:20 +0300 "Yordan Karadzhov (VMware)" wrote: > We simplify the way kprobes and tracefs instances are handled by > the Python module. The need of storing all kprobes and instances > created by the module in a binary search tree is eliminated by > defining new custom Python types for those objects. > > Changes in v2: > - Adding patches [PATCH 3/7, 6/7, 7/7] Hi Yordan, I took a look over these patches and they all look fine to me. -- Steve > > > Yordan Karadzhov (VMware) (7): > trace-cruncher: Use proper naming in common.h > trace-cruncher: Add type checking for the custom Python types > trace-cruncher: Allow for detachable custom objects > trace-cruncher: Define Python type for instances > trace-cruncher: Refactor the way libtracefs instances are handled > trace-cruncher: Define Python type for kprobes > trace-cruncher: Refactor the way kprobes are handled > > src/common.h | 34 +- > src/ftracepy-utils.c | 669 +++++++----------- > src/ftracepy-utils.h | 65 +- > src/ftracepy.c | 145 ++-- > tests/1_unit/test_01_ftracepy_unit.py | 288 +++----- > .../test_01_ftracepy_integration.py | 56 +- > tracecruncher/ft_utils.py | 14 +- > 7 files changed, 530 insertions(+), 741 deletions(-) >