From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: linux-trace-devel@vger.kernel.org
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 2/3] trace-cruncher: Have standard 'not existing' message
Date: Mon, 23 Aug 2021 15:53:47 +0300 [thread overview]
Message-ID: <20210823125348.145615-2-y.karadz@gmail.com> (raw)
In-Reply-To: <20210823125348.145615-1-y.karadz@gmail.com>
The string "(nil)" is used to state that an object
do not exists / is empty.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
src/common.h | 2 ++
src/ftracepy-utils.c | 6 +++---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/common.h b/src/common.h
index b7f6a87..476e4f1 100644
--- a/src/common.h
+++ b/src/common.h
@@ -24,6 +24,8 @@
static const char *NO_ARG = "/NONE/";
+#define TC_NIL_MSG "(nil)"
+
static inline bool is_all(const char *arg)
{
const char all[] = "all";
diff --git a/src/ftracepy-utils.c b/src/ftracepy-utils.c
index a3ae03a..4561a4d 100644
--- a/src/ftracepy-utils.c
+++ b/src/ftracepy-utils.c
@@ -68,7 +68,7 @@ PyObject *PyTepRecord_cpu(PyTepRecord* self)
PyObject *PyTepEvent_name(PyTepEvent* self)
{
- const char * name = self->ptrObj ? self->ptrObj->name : "nil";
+ const char *name = self->ptrObj ? self->ptrObj->name : TC_NIL_MSG;
return PyUnicode_FromString(name);
}
@@ -169,7 +169,7 @@ PyObject *PyTepEvent_parse_record_field(PyTepEvent* self, PyObject *args,
}
if (!field_size)
- return PyUnicode_FromString("(nil)");
+ return PyUnicode_FromString(TC_NIL_MSG);
if (field->flags & TEP_FIELD_IS_STRING) {
char *val_str = record->ptrObj->data + field_offset;
@@ -2098,7 +2098,7 @@ PyObject *PyFtrace_error_log(PyObject *self, PyObject *args,
ret = PyUnicode_FromString(err_log);
free(err_log);
} else if (ok) {
- ret = PyUnicode_FromString("(nil)");
+ ret = PyUnicode_FromString(TC_NIL_MSG);
}
return ret;
--
2.30.2
next prev parent reply other threads:[~2021-08-23 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 12:53 [PATCH 1/3] trace-cruncher: Add methods for accessing tracefs errorlog Yordan Karadzhov (VMware)
2021-08-23 12:53 ` Yordan Karadzhov (VMware) [this message]
2021-08-23 12:53 ` [PATCH 3/3] trace-cruncher: Print the tracefs log on an error Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823125348.145615-2-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).