From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: linux-trace-devel@vger.kernel.org
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 2/4] trace-cruncher: Add optional sort to available_system_events()
Date: Tue, 31 Aug 2021 15:53:55 +0300 [thread overview]
Message-ID: <20210831125357.56862-2-y.karadz@gmail.com> (raw)
In-Reply-To: <20210831125357.56862-1-y.karadz@gmail.com>
An optional parameter 'sort' is added. If set to True, the returned
list of event names is sorted in alphabetical order. The default
value of 'sort' is False.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
src/ftracepy-utils.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/ftracepy-utils.c b/src/ftracepy-utils.c
index 0fcadd8..f884106 100644
--- a/src/ftracepy-utils.c
+++ b/src/ftracepy-utils.c
@@ -733,18 +733,20 @@ PyObject *PyFtrace_available_event_systems(PyObject *self, PyObject *args,
PyObject *PyFtrace_available_system_events(PyObject *self, PyObject *args,
PyObject *kwargs)
{
- static char *kwlist[] = {"system", "instance", NULL};
+ static char *kwlist[] = {"system", "instance", "sort", NULL};
struct tracefs_instance *instance;
PyObject *py_inst = NULL;
const char *system;
+ int sort = false;
char **list;
if (!PyArg_ParseTupleAndKeywords(args,
kwargs,
- "s|O",
+ "s|Op",
kwlist,
&system,
- &py_inst)) {
+ &py_inst,
+ &sort)) {
return NULL;
}
@@ -757,7 +759,7 @@ PyObject *PyFtrace_available_system_events(PyObject *self, PyObject *args,
if (!list)
return NULL;
- return tfs_list2py_list(list, false);
+ return tfs_list2py_list(list, sort);
}
bool get_event_enable_file(struct tracefs_instance *instance,
--
2.30.2
next prev parent reply other threads:[~2021-08-31 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 12:53 [PATCH 1/4] trace-cruncher: Add optional sort to tfs_list2py_list() Yordan Karadzhov (VMware)
2021-08-31 12:53 ` Yordan Karadzhov (VMware) [this message]
2021-08-31 12:53 ` [PATCH 3/4] trace-cruncher: Add optional sort to available_event_systems() Yordan Karadzhov (VMware)
2021-08-31 12:53 ` [PATCH 4/4] trace-cruncher: Add tests for sorted events/systems Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831125357.56862-2-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).