From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-trace-devel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BE054C433EF
	for <linux-trace-devel@archiver.kernel.org>; Fri, 24 Sep 2021 15:54:37 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id A1FDF610FD
	for <linux-trace-devel@archiver.kernel.org>; Fri, 24 Sep 2021 15:54:37 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1347213AbhIXP4K (ORCPT
        <rfc822;linux-trace-devel@archiver.kernel.org>);
        Fri, 24 Sep 2021 11:56:10 -0400
Received: from mail.kernel.org ([198.145.29.99]:55968 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233562AbhIXP4J (ORCPT
        <rfc822;linux-trace-devel@vger.kernel.org>);
        Fri, 24 Sep 2021 11:56:09 -0400
Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 5D3836103B;
        Fri, 24 Sep 2021 15:54:36 +0000 (UTC)
Date:   Fri, 24 Sep 2021 11:54:34 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc:     "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>,
        Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] libtracefs: Add new constructors for histograms
Message-ID: <20210924115434.1b2c398e@gandalf.local.home>
In-Reply-To: <CAPpZLN7daWb2g_45CG3NzfKrEvK8NHNE+6k1NayYOL3u2b_EDw@mail.gmail.com>
References: <20210924095702.151826-1-y.karadz@gmail.com>
        <20210924095702.151826-2-y.karadz@gmail.com>
        <CAPpZLN7daWb2g_45CG3NzfKrEvK8NHNE+6k1NayYOL3u2b_EDw@mail.gmail.com>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-trace-devel.vger.kernel.org>
X-Mailing-List: linux-trace-devel@vger.kernel.org

On Fri, 24 Sep 2021 18:51:38 +0300
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:

> >  struct tracefs_hist *
> >  tracefs_hist_alloc(struct tep_handle *tep,  
> 
> For consistency with the newly added "alloc" APIs, this should be
> renamed. The dimensions of the histogram are part of the name, this
> one is for N dimensions:
>   tracefs_hist_alloc_1d()
>   tracefs_hist_alloc_2d()
>   tracefs_hist_alloc_nd()
> or something like that.

I rather not have the _nd().

 tracefs_hist_alloc_1d()
 tracefs_hist_alloc_2d() are more just helper handlers for specific cases.

 tracefs_hist_alloc() should be the "main" function, and hence doesn't need
any extra annotation.

-- Steve