Re: [PATCH v3] user_events: Enable user processes to create and write to trace events

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2888 bytes --]

Hi Beau,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Beau-Belgrave/user_events-Enable-user-processes-to-create-and-write-to-trace-events/20211019-071039
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 79df45731da68772d2285265864a52c900b8c65f
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c165bf4b91374ac0ffac76a9f93be466d37a5545
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Beau-Belgrave/user_events-Enable-user-processes-to-create-and-write-to-trace-events/20211019-071039
        git checkout c165bf4b91374ac0ffac76a9f93be466d37a5545
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/trace/trace_events_user.c: In function 'user_status_mmap':
>> kernel/trace/trace_events_user.c:880:38: error: 'PAGE_READONLY' undeclared (first use in this function); did you mean 'MNT_READONLY'?
     880 |                                size, PAGE_READONLY);
         |                                      ^~~~~~~~~~~~~
         |                                      MNT_READONLY
   kernel/trace/trace_events_user.c:880:38: note: each undeclared identifier is reported only once for each function it appears in
   kernel/trace/trace_events_user.c:881:1: error: control reaches end of non-void function [-Werror=return-type]
     881 | }
         | ^
   cc1: some warnings being treated as errors


vim +880 kernel/trace/trace_events_user.c

   867	
   868	/*
   869	 * Maps the shared page into the user process for checking if event is enabled.
   870	 */
   871	static int user_status_mmap(struct file *file, struct vm_area_struct *vma)
   872	{
   873		unsigned long size = vma->vm_end - vma->vm_start;
   874	
   875		if (size != MAX_EVENTS)
   876			return -EINVAL;
   877	
   878		return remap_pfn_range(vma, vma->vm_start,
   879				       virt_to_phys(register_page_data) >> PAGE_SHIFT,
 > 880				       size, PAGE_READONLY);
   881	}
   882	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 70961 bytes --]