linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org, y.karadz@gmail.com
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v2 07/12] libtracefs: Reimplement kprobe raw APIs
Date: Mon,  1 Nov 2021 11:08:59 +0200	[thread overview]
Message-ID: <20211101090904.81454-8-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20211101090904.81454-1-tz.stoyanov@gmail.com>

In order to unify the code and use the new dynamic event helpers, these
kprobe APIs are rewritten:
 kracefs_kprobe_raw()
 kracefs_kretprobe_raw()
The definition and logic of the APIs remain the same.

Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
 src/tracefs-kprobes.c | 38 ++++++++++----------------------------
 1 file changed, 10 insertions(+), 28 deletions(-)

diff --git a/src/tracefs-kprobes.c b/src/tracefs-kprobes.c
index 390e211..672e748 100644
--- a/src/tracefs-kprobes.c
+++ b/src/tracefs-kprobes.c
@@ -147,38 +147,20 @@ void tracefs_kprobe_free(struct tracefs_dynevent *kprobe)
 	dynevent_free(kprobe);
 }
 
-
-static int insert_kprobe(const char *type, const char *system,
-			 const char *event, const char *addr,
-			 const char *format)
+static int kprobe_raw(enum trace_dynevent_type type, const char *system,
+		      const char *event, const char *addr, const char *format)
 {
-	char *str;
+	static struct tracefs_dynevent *kp;
 	int ret;
 
-	if (!tracefs_file_exists(NULL, KPROBE_EVENTS))
-		return -1;
-
-	errno = EBADMSG;
-	if (!addr || !format)
-		return -1;
-
-	if (!event)
-		event = addr;
-
-	if (system)
-		ret = asprintf(&str, "%s:%s/%s %s %s\n",
-			       type, system, event, addr, format);
-	else
-		ret = asprintf(&str, "%s:%s %s %s\n",
-			       type, event, addr, format);
-
-	if (ret < 0)
+	kp = kprobe_alloc(type, system, event, addr, format);
+	if (!kp)
 		return -1;
 
-	ret = tracefs_instance_file_append(NULL, KPROBE_EVENTS, str);
-	free(str);
+	ret = dynevent_create(kp);
+	dynevent_free(kp);
 
-	return ret < 0 ? ret : 0;
+	return ret;
 }
 
 /**
@@ -204,7 +186,7 @@ static int insert_kprobe(const char *type, const char *system,
 int tracefs_kprobe_raw(const char *system, const char *event,
 		       const char *addr, const char *format)
 {
-	return insert_kprobe("p", system, event, addr, format);
+	return kprobe_raw(TRACE_DYNEVENT_KPROBE, system, event, addr, format);
 }
 
 /**
@@ -230,7 +212,7 @@ int tracefs_kprobe_raw(const char *system, const char *event,
 int tracefs_kretprobe_raw(const char *system, const char *event,
 			  const char *addr, const char *format)
 {
-	return insert_kprobe("r", system, event, addr, format);
+	return kprobe_raw(TRACE_DYNEVENT_KRETPROBE, system, event, addr, format);
 }
 
 /**
-- 
2.31.1


  parent reply	other threads:[~2021-11-01  9:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01  9:08 [PATCH v2 00/12] libtracefs dynamic events support Tzvetomir Stoyanov (VMware)
2021-11-01  9:08 ` [PATCH v2 01/12] libtracefs: Add new internal APIs for dynamic events Tzvetomir Stoyanov (VMware)
2021-11-01 17:06   ` Yordan Karadzhov
2021-11-02  4:33     ` Tzvetomir Stoyanov
2021-11-02 13:25       ` Steven Rostedt
2021-11-01  9:08 ` [PATCH v2 02/12] libtracefs: Rename tracefs_get_kprobes API Tzvetomir Stoyanov (VMware)
2021-11-01  9:08 ` [PATCH v2 03/12] libtracefs: New kprobes APIs Tzvetomir Stoyanov (VMware)
2021-11-01 17:22   ` Yordan Karadzhov
2021-11-02  4:58     ` Tzvetomir Stoyanov
2021-11-02  7:43       ` Yordan Karadzhov
2021-11-02 13:49         ` Steven Rostedt
2021-11-01  9:08 ` [PATCH v2 04/12] libtracefs: Remove redundant " Tzvetomir Stoyanov (VMware)
2021-11-01  9:08 ` [PATCH v2 05/12] libtracefs: Reimplement tracefs_kprobes_get API Tzvetomir Stoyanov (VMware)
2021-11-01  9:08 ` [PATCH v2 06/12] libtracefs: Change tracefs_kprobe_info API Tzvetomir Stoyanov (VMware)
2021-11-01  9:08 ` Tzvetomir Stoyanov (VMware) [this message]
2021-11-01  9:09 ` [PATCH v2 08/12] libtracefs: Extend kprobes unit test Tzvetomir Stoyanov (VMware)
2021-11-01  9:09 ` [PATCH v2 09/12] libtracefs: Update kprobes man pages Tzvetomir Stoyanov (VMware)
2021-11-01  9:09 ` [PATCH v2 10/12] libtracefs: Rename tracefs_synth_init API Tzvetomir Stoyanov (VMware)
2021-11-01  9:09 ` [PATCH v2 11/12] libtracefs: Use the internal dynamic events API when creating synthetic events Tzvetomir Stoyanov (VMware)
2021-11-01  9:09 ` [PATCH v2 12/12] libtracefs: Document tracefs_dynevent_list_free() API Tzvetomir Stoyanov (VMware)
2021-11-01 14:21 ` [PATCH v2 00/12] libtracefs dynamic events support Tzvetomir Stoyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211101090904.81454-8-tz.stoyanov@gmail.com \
    --to=tz.stoyanov@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).