From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Yordan Karadzhov <y.karadz@gmail.com>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 01/12] libtracefs: Add new internal APIs for dynamic events
Date: Tue, 2 Nov 2021 09:25:10 -0400 [thread overview]
Message-ID: <20211102092510.63bcf875@gandalf.local.home> (raw)
In-Reply-To: <CAPpZLN58N_B+WjoDHbSnD0xG-s6tOY49SdKFHNqohzPUVKybZw@mail.gmail.com>
On Tue, 2 Nov 2021 06:33:36 +0200
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
> > > +
> > > +#define DYNEVENTS_EVENTS "dynamic_events"
> > > +#define KPROBE_EVENTS "kprobe_events"
> >
> > A definition of KPROBE_EVENTS already exists in /utest/tracefs-utest.c and src/tracefs-kprobes.c
> >
> > Isn't better to move the whole group of definitions of filenames to include/tracefs-local.h?
>
> The unit test should use only the official library API, defined in
> tracefs.h. We could move these defines in the official API header, but
> I think these should be internal to the library.
Agreed. In fact, if one day the name changes (which is highly unlikely) we
want the unit tests to fail on that ;-)
-- Steve
next prev parent reply other threads:[~2021-11-02 13:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 9:08 [PATCH v2 00/12] libtracefs dynamic events support Tzvetomir Stoyanov (VMware)
2021-11-01 9:08 ` [PATCH v2 01/12] libtracefs: Add new internal APIs for dynamic events Tzvetomir Stoyanov (VMware)
2021-11-01 17:06 ` Yordan Karadzhov
2021-11-02 4:33 ` Tzvetomir Stoyanov
2021-11-02 13:25 ` Steven Rostedt [this message]
2021-11-01 9:08 ` [PATCH v2 02/12] libtracefs: Rename tracefs_get_kprobes API Tzvetomir Stoyanov (VMware)
2021-11-01 9:08 ` [PATCH v2 03/12] libtracefs: New kprobes APIs Tzvetomir Stoyanov (VMware)
2021-11-01 17:22 ` Yordan Karadzhov
2021-11-02 4:58 ` Tzvetomir Stoyanov
2021-11-02 7:43 ` Yordan Karadzhov
2021-11-02 13:49 ` Steven Rostedt
2021-11-01 9:08 ` [PATCH v2 04/12] libtracefs: Remove redundant " Tzvetomir Stoyanov (VMware)
2021-11-01 9:08 ` [PATCH v2 05/12] libtracefs: Reimplement tracefs_kprobes_get API Tzvetomir Stoyanov (VMware)
2021-11-01 9:08 ` [PATCH v2 06/12] libtracefs: Change tracefs_kprobe_info API Tzvetomir Stoyanov (VMware)
2021-11-01 9:08 ` [PATCH v2 07/12] libtracefs: Reimplement kprobe raw APIs Tzvetomir Stoyanov (VMware)
2021-11-01 9:09 ` [PATCH v2 08/12] libtracefs: Extend kprobes unit test Tzvetomir Stoyanov (VMware)
2021-11-01 9:09 ` [PATCH v2 09/12] libtracefs: Update kprobes man pages Tzvetomir Stoyanov (VMware)
2021-11-01 9:09 ` [PATCH v2 10/12] libtracefs: Rename tracefs_synth_init API Tzvetomir Stoyanov (VMware)
2021-11-01 9:09 ` [PATCH v2 11/12] libtracefs: Use the internal dynamic events API when creating synthetic events Tzvetomir Stoyanov (VMware)
2021-11-01 9:09 ` [PATCH v2 12/12] libtracefs: Document tracefs_dynevent_list_free() API Tzvetomir Stoyanov (VMware)
2021-11-01 14:21 ` [PATCH v2 00/12] libtracefs dynamic events support Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102092510.63bcf875@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).