linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 4/5] kernel-shark: Add 'Requires' to libkshark.pc
Date: Wed, 10 Nov 2021 11:29:47 -0500	[thread overview]
Message-ID: <20211110112947.321c7b55@gandalf.local.home> (raw)
In-Reply-To: <20211110143747.32833-4-y.karadz@gmail.com>

On Wed, 10 Nov 2021 16:37:46 +0200
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> --- a/build/libkshark.pc.cmake
> +++ b/build/libkshark.pc.cmake
> @@ -6,5 +6,7 @@ Name: libkshark
>  URL: https://git.kernel.org/pub/scm/utils/trace-cmd/kernel-shark.git/
>  Description: Library for accessing ftrace file system
>  Version: @KS_VERSION_STRING@
> +Requires: tracecmd >= @LIBTRACECMD_MIN_VERSION@

Note, when I added this, I get:

  # pkg-config --libs libkshark
  Package tracecmd was not found in the pkg-config search path.
  Perhaps you should add the directory containing `tracecmd.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'tracecmd', required by 'libkshark', not found

But if I switch it to libtracecmd, I get:

  # pkg-config --libs libkshark
  -lkshark -ltracecmd -ltracefs -ltraceevent 

-- Steve

> +Requires: json-c
>  Cflags: -I${includedir}
>  Libs: -L${libdir} -lkshark
> -- 


  reply	other threads:[~2021-11-10 16:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 14:37 [PATCH 1/5] kernel-shark: Silence a warning from 'cmake_clean.sh' Yordan Karadzhov (VMware)
2021-11-10 14:37 ` [PATCH 2/5] kernel-shark: Fix a warning from 'KsUtils.cpp' Yordan Karadzhov (VMware)
2021-11-10 14:37 ` [PATCH 3/5] kernel-shark: Update the README file Yordan Karadzhov (VMware)
2021-11-10 14:37 ` [PATCH 4/5] kernel-shark: Add 'Requires' to libkshark.pc Yordan Karadzhov (VMware)
2021-11-10 16:29   ` Steven Rostedt [this message]
2021-11-10 14:37 ` [PATCH 5/5] kernel-shark: Always run 'ldconfig' after installing libkshark Yordan Karadzhov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211110112947.321c7b55@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).