From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <y.karadz@gmail.com>
Cc: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] libtracefs: Transform tracefs_hist_add_sort_key()
Date: Wed, 10 Nov 2021 17:43:32 -0500 [thread overview]
Message-ID: <20211110174332.2b96f77e@gandalf.local.home> (raw)
In-Reply-To: <43ff18b5-8b79-970d-8670-375cd458f7be@gmail.com>
On Fri, 24 Sep 2021 19:56:41 +0300
Yordan Karadzhov <y.karadz@gmail.com> wrote:
> > The new name of the function, mentioned in the patch description, is
> > tracefs_hist_set_sort_key()
> > I like the name with "set" instead of "reset". The behaviour of the
> > function should be described in the function comments - to stress that
> > the old keys are overwritten.
> >
>
> Steven suggested to name it 'reset' in the review of the first version.
> Both 'set' and 'reset' are OK for me.
Looking at this now, I think "set" is a better name.
I'll modify it.
-- Steve
next prev parent reply other threads:[~2021-11-10 22:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 9:56 [PATCH v2 0/4] Modifications of some 'hist' APIs Yordan Karadzhov (VMware)
2021-09-24 9:56 ` [PATCH v2 1/4] libtracefs: Add new constructors for histograms Yordan Karadzhov (VMware)
2021-09-24 15:51 ` Tzvetomir Stoyanov
2021-09-24 15:54 ` Steven Rostedt
2021-09-24 16:53 ` Yordan Karadzhov
2021-09-24 9:57 ` [PATCH v2 2/4] libtracefs: Transform tracefs_hist_add_sort_key() Yordan Karadzhov (VMware)
2021-09-24 15:51 ` Tzvetomir Stoyanov
2021-09-24 16:56 ` Yordan Karadzhov
2021-11-10 22:43 ` Steven Rostedt [this message]
2021-09-24 9:57 ` [PATCH v2 3/4] libtracefs: Add new 'hist' APIs Yordan Karadzhov (VMware)
2021-09-24 9:57 ` [PATCH v2 4/4] libtracefs: Update 'hist' documentation Yordan Karadzhov (VMware)
2021-10-11 13:55 ` [RFC] Modifications of some 'hist' APIs Yordan Karadzhov
2021-10-13 2:14 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110174332.2b96f77e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).