From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-trace-devel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5C38EC433F5
	for <linux-trace-devel@archiver.kernel.org>; Wed, 10 Nov 2021 22:43:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 3FD9C610F8
	for <linux-trace-devel@archiver.kernel.org>; Wed, 10 Nov 2021 22:43:35 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233606AbhKJWqW (ORCPT
        <rfc822;linux-trace-devel@archiver.kernel.org>);
        Wed, 10 Nov 2021 17:46:22 -0500
Received: from mail.kernel.org ([198.145.29.99]:34590 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233583AbhKJWqW (ORCPT
        <rfc822;linux-trace-devel@vger.kernel.org>);
        Wed, 10 Nov 2021 17:46:22 -0500
Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id C803E611F2;
        Wed, 10 Nov 2021 22:43:33 +0000 (UTC)
Date:   Wed, 10 Nov 2021 17:43:32 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Yordan Karadzhov <y.karadz@gmail.com>
Cc:     Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
        Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] libtracefs: Transform
 tracefs_hist_add_sort_key()
Message-ID: <20211110174332.2b96f77e@gandalf.local.home>
In-Reply-To: <43ff18b5-8b79-970d-8670-375cd458f7be@gmail.com>
References: <20210924095702.151826-1-y.karadz@gmail.com>
        <20210924095702.151826-3-y.karadz@gmail.com>
        <CAPpZLN4yOiHBX2WRTWJHg+XUMULPUcx6KVE0_dNfP9hNaF-wgA@mail.gmail.com>
        <43ff18b5-8b79-970d-8670-375cd458f7be@gmail.com>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-trace-devel.vger.kernel.org>
X-Mailing-List: linux-trace-devel@vger.kernel.org

On Fri, 24 Sep 2021 19:56:41 +0300
Yordan Karadzhov <y.karadz@gmail.com> wrote:

> > The new name of the function, mentioned in the patch description, is
> >      tracefs_hist_set_sort_key()
> > I like the name with "set" instead of "reset". The behaviour of the
> > function should be described in the function comments - to stress that
> > the old keys are overwritten.
> >   
> 
> Steven suggested to name it 'reset' in the review of the first version.
> Both 'set' and 'reset' are OK for me.

Looking at this now, I think "set" is a better name.

I'll modify it.

-- Steve