From: Steven Rostedt <rostedt@goodmis.org>
To: "Jerome Marchand" <jmarchan@redhat.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] libtracecmd: don't ignore LDFLAGS when linking the shared libs
Date: Thu, 11 Nov 2021 13:11:31 -0500 [thread overview]
Message-ID: <20211111131131.585caf0a@gandalf.local.home> (raw)
In-Reply-To: <20211111180318.499099-1-jmarchan@redhat.com>
On Thu, 11 Nov 2021 19:03:18 +0100
"Jerome Marchand" <jmarchan@redhat.com> wrote:
> do_compile_shared_library should't ignore LDFLAGS. That makes it
> difficult for packager to follow their distribution packaging
> guidelines.
>
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
Thanks Jerome, I'll queue this up.
Looks like libtracefs may suffer from the same issue (and libtraceevent
looks fine).
https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
Did you want to submit a patch for libtracefs too?
-- Steve
> ---
> scripts/utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/utils.mk b/scripts/utils.mk
> index 6865a746..53b2b074 100644
> --- a/scripts/utils.mk
> +++ b/scripts/utils.mk
> @@ -72,7 +72,7 @@ do_build_static_lib = \
>
> do_compile_shared_library = \
> ($(print_shared_lib_compile) \
> - $(CC) --shared $^ '-Wl,-soname,$(@F),-rpath=$$ORIGIN' -o $@ $(LIBS))
> + $(CC) --shared $^ '-Wl,-soname,$(@F),-rpath=$$ORIGIN' -o $@ $(LDFLAGS) $(LIBS))
>
> do_compile_plugin_obj = \
> ($(print_plugin_obj_compile) \
next prev parent reply other threads:[~2021-11-11 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 18:03 [PATCH] libtracecmd: don't ignore LDFLAGS when linking the shared libs Jerome Marchand
2021-11-11 18:11 ` Steven Rostedt [this message]
2021-11-11 18:24 ` Jerome Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211111131131.585caf0a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jmarchan@redhat.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).