From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] Introduce configurable ring buffer page size
Date: Wed, 17 Nov 2021 12:10:15 -0500 [thread overview]
Message-ID: <20211117121015.55f6e1f1@gandalf.local.home> (raw)
In-Reply-To: <20211117154101.38659-1-tz.stoyanov@gmail.com>
On Wed, 17 Nov 2021 17:40:58 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> From: "Tzvetomir Stoyanov (VMware)" <tstoyanov@vmware.com>
>
> Currently the size of one buffer page is global for all buffers and it
> is hard coded to one system page. The patch set introduces configurable
> ring buffer page size, per ring buffer. A new user space interface is
> introduced, which allows to change the page size of the ftrace buffer, per
> ftrace instance.
A few of nits.
1. Even the cover letter should have a category ("tracing:").
2. The category is "tracing:" not "trace:"
3. These are kernel changes and should be sent to lkml and not
linux-trace-devel, as that mailing list is for tooling.
-- Steve
>
> Tzvetomir Stoyanov (VMware) (3):
> [RFC] trace: Page size per ring buffer
> [RFC] trace: Add interface for configuring trace ring buffer size
> [WiP] trace: Set new size of the ring buffer page
>
> include/linux/ring_buffer.h | 5 +-
> kernel/trace/ring_buffer.c | 251 +++++++++++++++++++++++++++---------
> kernel/trace/trace.c | 47 +++++++
> kernel/trace/trace_events.c | 71 ++++++++--
> 4 files changed, 304 insertions(+), 70 deletions(-)
>
next prev parent reply other threads:[~2021-11-17 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 15:40 [RFC PATCH 0/3] Introduce configurable ring buffer page size Tzvetomir Stoyanov (VMware)
2021-11-17 15:40 ` [PATCH 1/3] [RFC] trace: Page size per ring buffer Tzvetomir Stoyanov (VMware)
2021-11-17 18:17 ` Steven Rostedt
2021-11-18 4:32 ` Tzvetomir Stoyanov
2021-11-17 15:41 ` [PATCH 2/3] [RFC] trace: Add interface for configuring trace ring buffer size Tzvetomir Stoyanov (VMware)
2021-11-17 18:39 ` Steven Rostedt
2021-11-17 15:41 ` [PATCH 3/3] [WiP] trace: Set new size of the ring buffer page Tzvetomir Stoyanov (VMware)
2021-11-17 19:50 ` Steven Rostedt
2021-11-17 17:10 ` Steven Rostedt [this message]
2021-11-17 17:20 ` [RFC PATCH 0/3] Introduce configurable ring buffer page size Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117121015.55f6e1f1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).