linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: <linux-trace-devel@vger.kernel.org>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Subject: [PATCH 11/11] libtracefs/Documentation: Update stream example to have a parameter
Date: Mon, 22 Nov 2021 18:49:56 -0500	[thread overview]
Message-ID: <20211122234956.788401-12-rostedt@goodmis.org> (raw)
In-Reply-To: <20211122234956.788401-1-rostedt@goodmis.org>

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

Instead of writing the output of the tracing data to trace.txt, have the
example require a file name. As it is now compiled out, it should not
create some random file that the user will not expect.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 Documentation/libtracefs-stream.txt | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/Documentation/libtracefs-stream.txt b/Documentation/libtracefs-stream.txt
index 48fc8fa..7d723c5 100644
--- a/Documentation/libtracefs-stream.txt
+++ b/Documentation/libtracefs-stream.txt
@@ -47,6 +47,8 @@ EXAMPLE
 -------
 [source,c]
 --
+#include <stdio.h>
+#include <stdlib.h>
 #include <unistd.h>
 #include <signal.h>
 
@@ -57,13 +59,23 @@ void stop(int sig)
 	tracefs_trace_pipe_stop(NULL);
 }
 
-int main()
+int main(int argc, char **argv)
 {
 	mode_t mode = S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH;
-	const char *filename = "trace.txt";
-	int fd = creat(filename, mode);
+	const char *filename;
+	int fd;
 	int ret;
 
+	if (argc < 2) {
+		fprintf(stderr, "usage: %s output_file\n", argv[0]);
+		exit(-1);
+	}
+	filename = argv[1];
+	fd = creat(filename, mode);
+	if (fd < 0) {
+		perror(filename);
+		exit(-1);
+	}
 	signal(SIGINT, stop);
 	ret = tracefs_trace_pipe_stream(fd, NULL, SPLICE_F_NONBLOCK);
 	close(fd);
-- 
2.31.1


      parent reply	other threads:[~2021-11-22 23:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 23:49 [PATCH 00/11] libtracefs: Have all man page examples be executable Steven Rostedt
2021-11-22 23:49 ` [PATCH 01/11] libtracefs: Move creation of sqlhist into new samples directory Steven Rostedt
2021-11-22 23:49 ` [PATCH 02/11] libtracefs: Fix example in the dynamic events man page to compile Steven Rostedt
2021-11-22 23:49 ` [PATCH 03/11] libtracefs/Documentation: Fix man page examples to include the proper header Steven Rostedt
2021-11-22 23:49 ` [PATCH 04/11] tracefs/Documentation: Fix example in libtracefs-eprobes.txt to compile Steven Rostedt
2021-11-22 23:49 ` [PATCH 05/11] libtracefs: Make samples easily extract man page example programs Steven Rostedt
2021-11-22 23:49 ` [PATCH 06/11] libtracefs: Add new API tracefs_dynevent_get() Steven Rostedt
2021-11-22 23:49 ` [PATCH 07/11] libtracefs/Documentation: Fix example in libtracefs-error.txt Steven Rostedt
2021-11-22 23:49 ` [PATCH 08/11] libtracefs/Documentation: Fix function-filter call to tracefs_list_free() Steven Rostedt
2021-11-22 23:49 ` [PATCH 09/11] libtracefs/Documentation: Update libtracefs-hist-cont.txt to new API Steven Rostedt
2021-11-22 23:49 ` [PATCH 10/11] libtracefs: Add all working man page examples to samples Steven Rostedt
2021-11-22 23:49 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211122234956.788401-12-rostedt@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).