From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Beau Belgrave <beaub@linux.microsoft.com>,
linux-trace-devel@vger.kernel.org,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Subject: Re: [PATCH] libtraceevent: Add __rel_loc relative location attribute support
Date: Tue, 23 Nov 2021 21:05:43 +0900 [thread overview]
Message-ID: <20211123210543.06fed832b5ab3af31a789592@kernel.org> (raw)
In-Reply-To: <20211122223909.15f6fb50@rorschach.local.home>
On Mon, 22 Nov 2021 22:39:09 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 22 Nov 2021 18:36:57 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > @@ -3886,6 +3900,8 @@ static inline void dynamic_offset_field(struct tep_handle *tep,
> > unsigned int *len)
> > {
> > dynamic_offset(tep, field->size, data + field->offset, offset, len);
> > + if (field->flags & TEP_FIELD_IS_RELATIVE)
> > + offset += field->offset + field->size;
>
> I think you want *offset += field->offset + field->size;
Oops, good catch! Yes, that's right.
BTW, are there any tool I can use for testing this library?
Thank you,
>
> -- Steve
>
> > }
> >
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-11-23 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 9:36 [PATCH] libtraceevent: Add __rel_loc support Masami Hiramatsu
2021-11-22 9:36 ` [PATCH] libtraceevent: Add __rel_loc relative location attribute support Masami Hiramatsu
2021-11-23 3:39 ` Steven Rostedt
2021-11-23 12:05 ` Masami Hiramatsu [this message]
2021-11-23 14:49 ` Steven Rostedt
2021-11-23 13:36 ` [PATCH v2] " Masami Hiramatsu
2021-11-24 23:07 ` Steven Rostedt
2021-11-26 12:20 ` Masami Hiramatsu
2021-11-26 18:23 ` Steven Rostedt
2021-11-29 20:15 ` Beau Belgrave
2021-11-29 20:27 ` Steven Rostedt
2021-11-29 21:26 ` Beau Belgrave
2021-11-30 0:16 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123210543.06fed832b5ab3af31a789592@kernel.org \
--to=mhiramat@kernel.org \
--cc=beaub@linux.microsoft.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).