From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] trace-cmd library: Helper logic to update the trace buffer offset
Date: Wed, 24 Nov 2021 12:22:03 -0500 [thread overview]
Message-ID: <20211124122203.51a1dd40@gandalf.local.home> (raw)
In-Reply-To: <20211111150805.86419-4-tz.stoyanov@gmail.com>
On Thu, 11 Nov 2021 17:08:04 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> --- a/lib/trace-cmd/trace-output.c
> +++ b/lib/trace-cmd/trace-output.c
> @@ -1395,6 +1395,20 @@ int tracecmd_write_buffer_info(struct tracecmd_output *handle)
> return 0;
> }
>
> +static tsize_t get_buffer_file_offset(struct tracecmd_output *handle, const char *name)
> +{
>
> +static int update_buffer_cpu_offset(struct tracecmd_output *handle,
> + const char *name, tsize_t offset)
> +{
Let's not have patches that add static functions that are not used.
They should be added when they are used. I may just merge the patches.
-- Steve
next prev parent reply other threads:[~2021-11-24 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 15:08 [PATCH v3 0/4] Refactor the logic for writing trace data in the file Tzvetomir Stoyanov (VMware)
2021-11-11 15:08 ` [PATCH v3 1/4] trace-cmd library: Add internal database for trace buffers Tzvetomir Stoyanov (VMware)
2021-11-11 15:08 ` [PATCH v3 2/4] trace-cmd: Use the new trace buffers API Tzvetomir Stoyanov (VMware)
2021-11-24 17:19 ` Steven Rostedt
2021-11-11 15:08 ` [PATCH v3 3/4] trace-cmd library: Helper logic to update the trace buffer offset Tzvetomir Stoyanov (VMware)
2021-11-24 17:22 ` Steven Rostedt [this message]
2021-11-11 15:08 ` [PATCH v3 4/4] trace-cmd library: Refactor the logic for writing trace data in the file Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124122203.51a1dd40@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).