From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Beau Belgrave <beaub@linux.microsoft.com>,
linux-trace-devel@vger.kernel.org,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Subject: Re: [PATCH v2] libtraceevent: Add __rel_loc relative location attribute support
Date: Fri, 26 Nov 2021 13:23:03 -0500 [thread overview]
Message-ID: <20211126132303.25f4fd4d@oasis.local.home> (raw)
In-Reply-To: <20211126212026.e6b035ac8ec318b06030221f@kernel.org>
On Fri, 26 Nov 2021 21:20:26 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > We need to be careful about modifying content in event-parse.h. Because
> > this is exposed outside he library.
>
> Oh, I thought this is an internal header, because it is under src/ directory.
> However, indeed "TEP_FIELD_IS_*" referred from perf-tools, so this might be
> need to be exposed.
Yeah, we need to fix this.
The issue was that this is loaded with legacy code. The code was
created in trace-cmd, ported to the kernel into tools/lib/traceevent,
then pulled out into it's own directory. The poor library had so many
foster parents, that it wasn't ready to go out on its own.
I'll fix some of this before posting a new version.
-- Steve
next prev parent reply other threads:[~2021-11-26 18:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 9:36 [PATCH] libtraceevent: Add __rel_loc support Masami Hiramatsu
2021-11-22 9:36 ` [PATCH] libtraceevent: Add __rel_loc relative location attribute support Masami Hiramatsu
2021-11-23 3:39 ` Steven Rostedt
2021-11-23 12:05 ` Masami Hiramatsu
2021-11-23 14:49 ` Steven Rostedt
2021-11-23 13:36 ` [PATCH v2] " Masami Hiramatsu
2021-11-24 23:07 ` Steven Rostedt
2021-11-26 12:20 ` Masami Hiramatsu
2021-11-26 18:23 ` Steven Rostedt [this message]
2021-11-29 20:15 ` Beau Belgrave
2021-11-29 20:27 ` Steven Rostedt
2021-11-29 21:26 ` Beau Belgrave
2021-11-30 0:16 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211126132303.25f4fd4d@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=beaub@linux.microsoft.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).