From: Steven Rostedt <rostedt@goodmis.org>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-devel@vger.kernel.org,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Subject: Re: [PATCH v2] libtraceevent: Add __rel_loc relative location attribute support
Date: Mon, 29 Nov 2021 15:27:04 -0500 [thread overview]
Message-ID: <20211129152704.7489dd16@gandalf.local.home> (raw)
In-Reply-To: <20211129201507.GA30603@kbox>
On Mon, 29 Nov 2021 12:15:07 -0800
Beau Belgrave <beaub@linux.microsoft.com> wrote:
> > @@ -3308,19 +3318,23 @@ process_function(struct tep_event *event, struct tep_print_arg *arg,
> > free_token(token);
> > return process_int_array(event, arg, tok);
> > }
> > - if (strcmp(token, "__get_str") == 0) {
> > + if (strcmp(token, "__get_str") == 0 ||
> > + strcmp(token, "__get_rel_str") == 0) {
>
> Should user_events use __get_rel_str vs __get_str for the print_fmt?
> Both __dyn_loc and __rel_loc use __get_str currently.
I'm guessing that it should use the get_rel_str(), as get_str() will use
the absolute offset and not the relative one.
-- Steve
next prev parent reply other threads:[~2021-11-29 20:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 9:36 [PATCH] libtraceevent: Add __rel_loc support Masami Hiramatsu
2021-11-22 9:36 ` [PATCH] libtraceevent: Add __rel_loc relative location attribute support Masami Hiramatsu
2021-11-23 3:39 ` Steven Rostedt
2021-11-23 12:05 ` Masami Hiramatsu
2021-11-23 14:49 ` Steven Rostedt
2021-11-23 13:36 ` [PATCH v2] " Masami Hiramatsu
2021-11-24 23:07 ` Steven Rostedt
2021-11-26 12:20 ` Masami Hiramatsu
2021-11-26 18:23 ` Steven Rostedt
2021-11-29 20:15 ` Beau Belgrave
2021-11-29 20:27 ` Steven Rostedt [this message]
2021-11-29 21:26 ` Beau Belgrave
2021-11-30 0:16 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129152704.7489dd16@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=beaub@linux.microsoft.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).