From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v6 22/23] trace-cmd: Write buffers metadata in trace files version 6
Date: Thu, 2 Dec 2021 14:21:51 +0200 [thread overview]
Message-ID: <20211202122152.43275-23-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20211202122152.43275-1-tz.stoyanov@gmail.com>
When creating a trace file, tracecmd_write_buffer_info() should be
called, to write buffers metadata in file version 6 trace files.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
tracecmd/trace-listen.c | 3 +++
tracecmd/trace-record.c | 4 ++++
2 files changed, 7 insertions(+)
diff --git a/tracecmd/trace-listen.c b/tracecmd/trace-listen.c
index 45ba1211..874ecd61 100644
--- a/tracecmd/trace-listen.c
+++ b/tracecmd/trace-listen.c
@@ -604,6 +604,9 @@ static int put_together_file(int cpus, int ofd, const char *node,
if (write_options) {
ret = tracecmd_write_cpus(handle, cpus);
+ if (ret)
+ goto out;
+ ret = tracecmd_write_buffer_info(handle);
if (ret)
goto out;
ret = tracecmd_write_options(handle);
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index 2c222ed9..442e55bd 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -3729,6 +3729,9 @@ setup_connection(struct buffer_instance *instance, struct common_record_context
if (ret)
goto error;
ret = tracecmd_write_cpus(network_handle, instance->cpu_count);
+ if (ret)
+ goto error;
+ ret = tracecmd_write_buffer_info(network_handle);
if (ret)
goto error;
ret = tracecmd_write_options(network_handle);
@@ -4092,6 +4095,7 @@ static void setup_agent(struct buffer_instance *instance,
add_options(network_handle, ctx);
tracecmd_write_cmdlines(network_handle);
tracecmd_write_cpus(network_handle, instance->cpu_count);
+ tracecmd_write_buffer_info(network_handle);
tracecmd_write_options(network_handle);
tracecmd_msg_finish_sending_data(instance->msg_handle);
instance->network_handle = network_handle;
--
2.33.1
next prev parent reply other threads:[~2021-12-02 12:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 12:21 [PATCH v6 00/23] Trace file version 7 - sections Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 01/23] trace-cmd library: Define trace file version 7 Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 02/23] trace-cmd library: Add cache functionality to network message handler Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 03/23] trace-cmd library: New APIs to get and set version of output handler Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 04/23] trace-cmd library: Add internal helper function for writing headers before file sections Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 05/23] trace-cmd library: Write header " Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 06/23] trace-cmd library: Add multiple options sections in trace file version 7 Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 07/23] trace-cmd library: Do not write CPU count section in trace files " Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 08/23] trace-cmd library: Move CPU flyrecord trace metadata into the buffer option, for trace file " Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 09/23] trace-cmd library: Add section header before flyrecord trace data Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 10/23] trace-cmd library: Fit CPU latency trace data in the new trace file version 7 format Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 11/23] trace-cmd library: Add macro to check file state on reading Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 12/23] trace-cmd library: Introduce sections in trace file reading logic Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 13/23] trace-cmd library: Initialize internal sections database on file read Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 14/23] trace-cmd library: Use sections database when reading parts of the trace file Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 15/23] trace-cmd library: Read headers from trace file version 7 Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 16/23] trace-cmd library: Read extended BUFFER option Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 17/23] trace-cmd library: Handle the extended DONE option Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 18/23] trace-cmd library: Initialize CPU data for reading from version 7 trace files Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 19/23] trace-cmd library: Handle latency trace in version 7 files Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 20/23] trace-cmd library: Handle buffer trace data init for " Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` [PATCH v6 21/23] trace-cmd report: Use the new latency API to read data Tzvetomir Stoyanov (VMware)
2021-12-02 12:21 ` Tzvetomir Stoyanov (VMware) [this message]
2021-12-02 12:21 ` [PATCH v6 23/23] trace-cmd report: Add new parameter for trace file version Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202122152.43275-23-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).