From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>, kernel <kernel@axis.com>
Subject: Re: [PATCH v2] trace-cmd report: Avoid crash on unknown event
Date: Wed, 8 Dec 2021 16:00:05 +0100 [thread overview]
Message-ID: <20211208150004.GA15557@axis.com> (raw)
In-Reply-To: <20211208094511.3efadb41@gandalf.local.home>
On Wed, Dec 08, 2021 at 03:45:11PM +0100, Steven Rostedt wrote:
> On Wed, 8 Dec 2021 15:34:02 +0100
> Vincent Whitchurch <vincent.whitchurch@axis.com> wrote:
>
> > Do not segfault if the event cannot be found for some reason and
> > tep_find_event_by_record() returns NULL.
> >
> > With this patch:
> >
> > kworker/u8:0-7 [003] 1.245773: sched_stat_runtime: comm=kworker/u8:...
> > [UNKNOWN EVENT][UNKNOWN EVENT] (NULL): [UNKNOWN EVENT]
> > kworker/u8:0-7 [003] 1.245776: sched_switch: kworker/u8:0:7 [120] W...
> >
> > Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
>
> Hi Vincent,
>
> I already applied the update.
>
> https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/commit/?id=196a3a63c466204f3e8f4fa35194fc9ab7cb1ab7
>
> Sorry, I waited a bit but your reply sounded like you wanted me to do it.
No worries, thanks. I did think it would be easier for you to commit
it. I pulled before reworking the patch but I didn't see your commit.
It turns out I was using a clone from the following (wrong) git which
hasn't been updated in months...
https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/
next prev parent reply other threads:[~2021-12-08 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 14:34 [PATCH v2] trace-cmd report: Avoid crash on unknown event Vincent Whitchurch
2021-12-08 14:45 ` Steven Rostedt
2021-12-08 15:00 ` Vincent Whitchurch [this message]
2021-12-08 15:07 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208150004.GA15557@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=kernel@axis.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).