linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v7 11/25] trace-cmd library: Fit CPU latency trace data in the new trace file version 7 format
Date: Fri, 10 Dec 2021 12:54:34 +0200	[thread overview]
Message-ID: <20211210105448.97850-12-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20211210105448.97850-1-tz.stoyanov@gmail.com>

Trace file version 7 format is based on sections. To fit the latency
trace data in this structure, a new section and option for it is
defined:
  BUFFER_TEXT
It is similar to the BUFFER section which holds the flyrecord binary
data, but has a latency specific design for text data. The BUFFER_TEXT
section has:
 - section header, as all other sections
 - compression of the trace data, optional
 - corresponding trace option, pointing to the section

Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
 .../include/private/trace-cmd-private.h       |  1 +
 lib/trace-cmd/trace-output.c                  | 24 ++++++++++++++++---
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/lib/trace-cmd/include/private/trace-cmd-private.h b/lib/trace-cmd/include/private/trace-cmd-private.h
index 047fc26f..d8ee9b74 100644
--- a/lib/trace-cmd/include/private/trace-cmd-private.h
+++ b/lib/trace-cmd/include/private/trace-cmd-private.h
@@ -145,6 +145,7 @@ enum {
 	TRACECMD_OPTION_KALLSYMS,
 	TRACECMD_OPTION_PRINTK,
 	TRACECMD_OPTION_CMDLINES,
+	TRACECMD_OPTION_BUFFER_TEXT,
 	TRACECMD_OPTION_MAX,
 };
 
diff --git a/lib/trace-cmd/trace-output.c b/lib/trace-cmd/trace-output.c
index 44050dc8..47227728 100644
--- a/lib/trace-cmd/trace-output.c
+++ b/lib/trace-cmd/trace-output.c
@@ -1874,7 +1874,9 @@ out_add_buffer_option_v7(struct tracecmd_output *handle, const char *name,
 
 struct tracecmd_output *tracecmd_create_file_latency(const char *output_file, int cpus)
 {
+	enum tracecmd_section_flags flags = 0;
 	struct tracecmd_output *handle;
+	tsize_t offset;
 	char *path;
 
 	handle = tracecmd_output_create(output_file);
@@ -1891,7 +1893,8 @@ struct tracecmd_output *tracecmd_create_file_latency(const char *output_file, in
 
 	if (tracecmd_write_cpus(handle, cpus) < 0)
 		goto out_free;
-
+	if (tracecmd_write_buffer_info(handle) < 0)
+		goto out_free;
 	if (tracecmd_write_options(handle) < 0)
 		goto out_free;
 
@@ -1901,23 +1904,38 @@ struct tracecmd_output *tracecmd_create_file_latency(const char *output_file, in
 		goto out_free;
 	}
 
-	if (do_write_check(handle, "latency  ", 10))
+	if (!HAS_SECTIONS(handle) && do_write_check(handle, "latency  ", 10))
 		goto out_free;
 
 	path = get_tracing_file(handle, "trace");
 	if (!path)
 		goto out_free;
 
+	offset = do_lseek(handle, 0, SEEK_CUR);
+	if (HAS_SECTIONS(handle) &&
+	    !out_add_buffer_option_v7(handle, "", TRACECMD_OPTION_BUFFER_TEXT, offset, 0, NULL))
+		goto out_free;
+
+	offset = out_write_section_header(handle, TRACECMD_OPTION_BUFFER_TEXT,
+					  "buffer latency", flags, false);
+
 	copy_file(handle, path);
+	if (out_update_section_header(handle, offset))
+		goto out_free;
 
 	put_tracing_file(path);
 
 	handle->file_state = TRACECMD_FILE_CPU_LATENCY;
 
+	if (HAS_SECTIONS(handle))
+		tracecmd_write_options(handle);
+
 	return handle;
 
 out_free:
-	tracecmd_output_close(handle);
+	if (handle)
+		tracecmd_output_close(handle);
+	unlink(output_file);
 	return NULL;
 }
 
-- 
2.33.1


  parent reply	other threads:[~2021-12-10 10:55 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 10:54 [PATCH v7 00/25] Trace file version 7 - sections Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 01/25] trace-cmd library: Define trace file version 7 Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 02/25] trace-cmd library: Add cache functionality to network message handler Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 03/25] trace-cmd library: New APIs to get and set version of output handler Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 04/25] trace-cmd library: Add strings section in trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-15 12:53   ` Steven Rostedt
2022-01-17  9:32     ` Tzvetomir Stoyanov
2022-01-17 14:40       ` Steven Rostedt
2022-01-17 14:44         ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 05/25] trace-cmd library: Add internal helper function for writing headers before file sections Tzvetomir Stoyanov (VMware)
2022-01-15 12:58   ` Steven Rostedt
2022-01-17 10:08     ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 06/25] trace-cmd library: Write header " Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 07/25] trace-cmd library: Add multiple options sections in trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-15 14:57   ` Steven Rostedt
2022-01-17 17:12     ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 08/25] trace-cmd library: Do not write CPU count section in trace files " Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 09/25] trace-cmd library: Move CPU flyrecord trace metadata into the buffer option, for trace file " Tzvetomir Stoyanov (VMware)
2022-01-15 15:12   ` Steven Rostedt
2022-01-17 13:43     ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 10/25] trace-cmd library: Add section header before flyrecord trace data Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` Tzvetomir Stoyanov (VMware) [this message]
2022-01-15 15:20   ` [PATCH v7 11/25] trace-cmd library: Fit CPU latency trace data in the new trace file version 7 format Steven Rostedt
2022-01-17 14:11     ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 12/25] trace-cmd library: Add macro to check file state on reading Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 13/25] trace-cmd library: Introduce sections in trace file reading logic Tzvetomir Stoyanov (VMware)
2022-01-15 15:27   ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 14/25] trace-cmd library: Initialize internal sections database on file read Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 15/25] trace-cmd library: Use sections database when reading parts of the trace file Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 16/25] trace-cmd library: Read headers from trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-15 15:59   ` Steven Rostedt
2022-01-17 15:47     ` Tzvetomir Stoyanov
2022-01-17 16:17       ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 17/25] trace-cmd library: Read strings sections on file load Tzvetomir Stoyanov (VMware)
2022-01-15 16:04   ` Steven Rostedt
2022-01-17 16:11     ` Tzvetomir Stoyanov
2022-01-17 16:18       ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 18/25] trace-cmd library: Read extended BUFFER option Tzvetomir Stoyanov (VMware)
2022-01-15 16:10   ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 19/25] trace-cmd library: Handle the extended DONE option Tzvetomir Stoyanov (VMware)
2022-01-15 16:12   ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 20/25] trace-cmd library: Initialize CPU data for reading from version 7 trace files Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 21/25] trace-cmd library: Handle latency trace in version 7 files Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 22/25] trace-cmd library: Handle buffer trace data init for " Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 23/25] trace-cmd report: Use the new latency API to read data Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 24/25] trace-cmd: Write buffers metadata in trace files version 6 Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 25/25] trace-cmd report: Add new parameter for trace file version Tzvetomir Stoyanov (VMware)
2022-01-15 16:20   ` Steven Rostedt
2022-01-15 16:21 ` [PATCH v7 00/25] Trace file version 7 - sections Steven Rostedt
2022-01-17  9:03   ` Tzvetomir Stoyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211210105448.97850-12-tz.stoyanov@gmail.com \
    --to=tz.stoyanov@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).