From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v8 11/25] trace-cmd library: Fit CPU latency trace data in the new trace file version 7 format
Date: Wed, 19 Jan 2022 10:24:53 +0200 [thread overview]
Message-ID: <20220119082507.245600-12-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20220119082507.245600-1-tz.stoyanov@gmail.com>
Trace file version 7 format is based on sections. To fit the latency
trace data in this structure, a new section and option for it is
defined:
BUFFER_TEXT
It is similar to the BUFFER section which holds the flyrecord binary
data, but has a latency specific design for text data. The BUFFER_TEXT
section has:
- section header, as all other sections
- compression of the trace data, optional
- corresponding trace option, pointing to the section
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
.../include/private/trace-cmd-private.h | 1 +
lib/trace-cmd/trace-output.c | 20 +++++++++++++++++--
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/lib/trace-cmd/include/private/trace-cmd-private.h b/lib/trace-cmd/include/private/trace-cmd-private.h
index eaf51f5f..953297f3 100644
--- a/lib/trace-cmd/include/private/trace-cmd-private.h
+++ b/lib/trace-cmd/include/private/trace-cmd-private.h
@@ -150,6 +150,7 @@ enum {
TRACECMD_OPTION_KALLSYMS,
TRACECMD_OPTION_PRINTK,
TRACECMD_OPTION_CMDLINES,
+ TRACECMD_OPTION_BUFFER_TEXT,
TRACECMD_OPTION_MAX,
};
diff --git a/lib/trace-cmd/trace-output.c b/lib/trace-cmd/trace-output.c
index 30bf0dd1..7e1849c8 100644
--- a/lib/trace-cmd/trace-output.c
+++ b/lib/trace-cmd/trace-output.c
@@ -1892,7 +1892,9 @@ out_add_buffer_option(struct tracecmd_output *handle, const char *name,
struct tracecmd_output *tracecmd_create_file_latency(const char *output_file, int cpus)
{
+ enum tracecmd_section_flags flags = 0;
struct tracecmd_output *handle;
+ tsize_t offset;
char *path;
handle = tracecmd_output_create(output_file);
@@ -1909,7 +1911,8 @@ struct tracecmd_output *tracecmd_create_file_latency(const char *output_file, in
if (tracecmd_write_cpus(handle, cpus) < 0)
goto out_free;
-
+ if (tracecmd_write_buffer_info(handle) < 0)
+ goto out_free;
if (tracecmd_write_options(handle) < 0)
goto out_free;
@@ -1919,19 +1922,32 @@ struct tracecmd_output *tracecmd_create_file_latency(const char *output_file, in
goto out_free;
}
- if (do_write_check(handle, "latency ", 10))
+ if (!HAS_SECTIONS(handle) && do_write_check(handle, "latency ", 10))
goto out_free;
path = get_tracing_file(handle, "trace");
if (!path)
goto out_free;
+ offset = do_lseek(handle, 0, SEEK_CUR);
+ if (HAS_SECTIONS(handle) &&
+ !out_add_buffer_option(handle, "", TRACECMD_OPTION_BUFFER_TEXT, offset, 0, NULL))
+ goto out_free;
+
+ offset = out_write_section_header(handle, TRACECMD_OPTION_BUFFER_TEXT,
+ "buffer latency", flags, false);
+
copy_file(handle, path);
+ if (out_update_section_header(handle, offset))
+ goto out_free;
put_tracing_file(path);
handle->file_state = TRACECMD_FILE_CPU_LATENCY;
+ if (HAS_SECTIONS(handle))
+ tracecmd_write_options(handle);
+
return handle;
out_free:
--
2.34.1
next prev parent reply other threads:[~2022-01-19 8:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 8:24 [PATCH v8 00/25] Trace file version 7 - sections Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 01/25] trace-cmd library: Define trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 02/25] trace-cmd library: Add cache functionality to network message handler Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 03/25] trace-cmd library: New APIs to get and set version of output handler Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 04/25] trace-cmd library: Add strings section in trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 05/25] trace-cmd library: Add internal helper function for writing headers before file sections Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 06/25] trace-cmd library: Write header " Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 07/25] trace-cmd library: Add multiple options sections in trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 08/25] trace-cmd library: Do not write CPU count section in trace files " Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 09/25] trace-cmd library: Move CPU flyrecord trace metadata into the buffer option, for trace file " Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 10/25] trace-cmd library: Add section header before flyrecord trace data Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` Tzvetomir Stoyanov (VMware) [this message]
2022-01-19 8:24 ` [PATCH v8 12/25] trace-cmd library: Add macro to check file state on reading Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 13/25] trace-cmd library: Introduce sections in trace file reading logic Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 14/25] trace-cmd library: Initialize internal sections database on file read Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 15/25] trace-cmd library: Use sections database when reading parts of the trace file Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 16/25] trace-cmd library: Read headers from trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-19 8:24 ` [PATCH v8 17/25] trace-cmd library: Read strings sections on file load Tzvetomir Stoyanov (VMware)
2022-01-19 8:25 ` [PATCH v8 18/25] trace-cmd library: Read extended BUFFER option Tzvetomir Stoyanov (VMware)
2022-01-19 8:25 ` [PATCH v8 19/25] trace-cmd library: Handle the extended DONE option Tzvetomir Stoyanov (VMware)
2022-01-19 8:25 ` [PATCH v8 20/25] trace-cmd library: Initialize CPU data for reading from version 7 trace files Tzvetomir Stoyanov (VMware)
2022-01-19 8:25 ` [PATCH v8 21/25] trace-cmd library: Handle latency trace in version 7 files Tzvetomir Stoyanov (VMware)
2022-01-19 8:25 ` [PATCH v8 22/25] trace-cmd library: Handle buffer trace data init for " Tzvetomir Stoyanov (VMware)
2022-01-19 8:25 ` [PATCH v8 23/25] trace-cmd report: Use the new latency API to read data Tzvetomir Stoyanov (VMware)
2022-01-19 8:25 ` [PATCH v8 24/25] trace-cmd: Write buffers metadata in trace files version 6 Tzvetomir Stoyanov (VMware)
2022-01-19 8:25 ` [PATCH v8 25/25] trace-cmd record: Add new parameter for trace file version Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119082507.245600-12-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).