From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: linux-trace-devel@vger.kernel.org
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 1/2] trace-cruncher: Cleanup in class event
Date: Wed, 26 Jan 2022 14:31:13 +0200 [thread overview]
Message-ID: <20220126123114.214956-1-y.karadz@gmail.com> (raw)
The 'instance_list' field of the class event is a legacy from an old
implementation of the cleanup that was done in the destructor of the
class. Currently this field is useless and has to be removed.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
tracecruncher/ft_utils.py | 7 -------
1 file changed, 7 deletions(-)
diff --git a/tracecruncher/ft_utils.py b/tracecruncher/ft_utils.py
index ed4bdcd..e1126ad 100644
--- a/tracecruncher/ft_utils.py
+++ b/tracecruncher/ft_utils.py
@@ -43,7 +43,6 @@ class event:
"""
self.system = system
self.name = name
- self.instance_list = []
if static:
self.evt_id = find_event_id(system, name)
if self.evt_id < 0:
@@ -61,22 +60,16 @@ class event:
"""
if instance is None:
ft.enable_event(system=self.system, event=self.name)
- self.instance_list.append('top')
else:
ft.enable_event(instance=instance, system=self.system, event=self.name)
- self.instance_list.append(instance)
-
- self.instance_list = list(set(self.instance_list))
def disable(self, instance=None):
""" Disable this event.
"""
if instance is None:
ft.disable_event(system=self.system, event=self.name)
- self.instance_list.remove('top')
else:
ft.disable_event(instance=instance,system=self.system, event=self.name)
- self.instance_list.remove(instance)
def set_filter(self, filter, instance=None):
""" Define a filter for this event.
--
2.32.0
next reply other threads:[~2022-01-26 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 12:31 Yordan Karadzhov (VMware) [this message]
2022-01-26 12:31 ` [PATCH 2/2] trace-cruncher: Add no_arg() Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126123114.214956-1-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).