From: Steven Rostedt <rostedt@goodmis.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] libtracefs: clean also docs by default
Date: Thu, 3 Feb 2022 21:41:06 -0500 [thread overview]
Message-ID: <20220203214106.458cb2c4@gandalf.local.home> (raw)
In-Reply-To: <20220124105252.64897-1-krzysztof.kozlowski@canonical.com>
On Mon, 24 Jan 2022 11:52:51 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:
> Logical is that `make clean` cleans everything done from build, not only
> parts. Leaving the documentation unclean requires additional step
> when building for example Debian packages:
>
> $ dpkg-buildpackage -us -uc
> ...
> dpkg-source: info: local changes detected, the modified files are:
The reason we did this is because docs are not made by default.
(Yes you can say the same about utest, src and samples but those are all
code).
I've always kept the doc build (and cleanup) separate from the normal build.
Is it normal to remove the docs in other projects?
-- Steve
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 544684c1c37c..4650d15d64e9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -375,6 +375,7 @@ samples: libtracefs.a force
> $(Q)$(call descend,$(src)/samples,all)
>
> clean:
> + $(Q)$(call descend_clean,Documentation)
> $(Q)$(call descend_clean,utest)
> $(Q)$(call descend_clean,src)
> $(Q)$(call descend_clean,samples)
next prev parent reply other threads:[~2022-02-04 2:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 10:52 [PATCH 1/2] libtracefs: clean also docs by default Krzysztof Kozlowski
2022-01-24 10:52 ` [PATCH 2/2] libtracefs: fix utest linking path Krzysztof Kozlowski
2022-02-04 2:44 ` Steven Rostedt
2022-02-04 2:41 ` Steven Rostedt [this message]
2022-02-04 8:59 ` [PATCH 1/2] libtracefs: clean also docs by default Krzysztof Kozlowski
2022-02-04 13:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220203214106.458cb2c4@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).