From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd reset: Clear all dynamic events
Date: Fri, 11 Feb 2022 21:56:39 -0500 [thread overview]
Message-ID: <20220211215639.2bdffbee@rorschach.local.home> (raw)
In-Reply-To: <20220114105748.46761-1-tz.stoyanov@gmail.com>
On Fri, 14 Jan 2022 12:57:48 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> + /* Clear event probes first, as they may be attached to other dynamic event */
> + tracefs_dynevent_destroy_all(TRACEFS_DYNEVENT_EPROBE, true);
> + tracefs_dynevent_destroy_all(TRACEFS_DYNEVENT_KPROBE |
> + TRACEFS_DYNEVENT_KRETPROBE |
> + TRACEFS_DYNEVENT_UPROBE |
> + TRACEFS_DYNEVENT_URETPROBE |
> + TRACEFS_DYNEVENT_SYNTH,
> + true);
> }
I accepted this patch, but really, tracefs needs something to define:
TRACEFS_DYNEVENT_ALL
as callers should not have to call out each type of dynamic event.
Especially when we are about to add new dynamic events, causing this to
break again.
Want to add that?
Thanks Tzvetomir,
-- Steve
next prev parent reply other threads:[~2022-02-12 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 10:57 [PATCH] trace-cmd reset: Clear all dynamic events Tzvetomir Stoyanov (VMware)
2022-02-12 2:56 ` Steven Rostedt [this message]
2022-02-14 4:15 ` Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211215639.2bdffbee@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).