* [PATCH] trace-cmd report: Print version of file being read
@ 2022-02-24 3:04 Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2022-02-24 3:04 UTC (permalink / raw)
To: Linux Trace Devel
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
The print of the version is no longer done by default. This should be, but
was changed when moved to the libtracecmd, which now uses tracecmd_info()
to output it. But since default loglevel is TEP_LOG_CRITICAL it is not
displayed.
Set the default loglevel for tracecmd to TEP_LOG_INFO, as tracecmd is not
as noisy as the other libraries may be.
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
lib/trace-cmd/trace-input.c | 2 +-
lib/trace-cmd/trace-util.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index ae3a9bbd01e1..b7f7c58fa90e 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -4168,7 +4168,7 @@ struct tracecmd_input *tracecmd_alloc_fd(int fd, int flags)
version = read_string(handle);
if (!version)
goto failed_read;
- tracecmd_info("version = %s\n", version);
+ tracecmd_info("version = %s", version);
ver = strtol(version, NULL, 10);
if (!ver && errno)
goto failed_read;
diff --git a/lib/trace-cmd/trace-util.c b/lib/trace-cmd/trace-util.c
index 2cf8974ef4ee..91e8a30fb90b 100644
--- a/lib/trace-cmd/trace-util.c
+++ b/lib/trace-cmd/trace-util.c
@@ -30,7 +30,7 @@
#define PROC_STACK_FILE "/proc/sys/kernel/stack_tracer_enabled"
static bool debug;
-static int log_level = TEP_LOG_CRITICAL;
+static int log_level = TEP_LOG_INFO;
static FILE *logfp;
const static struct {
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-24 3:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-24 3:04 [PATCH] trace-cmd report: Print version of file being read Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).