From: Ian Rogers <irogers@google.com>
To: linux-trace-devel@vger.kernel.org,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Ian Rogers <irogers@google.com>
Subject: [PATCH 3/3] libtracefs: Move initialization below a null test.
Date: Thu, 24 Feb 2022 15:48:23 -0800 [thread overview]
Message-ID: <20220224234823.1190425-3-irogers@google.com> (raw)
In-Reply-To: <20220224234823.1190425-1-irogers@google.com>
Computing the address from a NULL pointer results in undefined behavior
which things like undefined behavior sanitizer promote into real
failures.
Signed-off-by: Ian Rogers <irogers@google.com>
---
src/tracefs-dynevents.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/tracefs-dynevents.c b/src/tracefs-dynevents.c
index 61804b9..8fee474 100644
--- a/src/tracefs-dynevents.c
+++ b/src/tracefs-dynevents.c
@@ -724,13 +724,18 @@ tracefs_dynevent_info(struct tracefs_dynevent *dynevent, char **system,
char **event, char **prefix, char **addr, char **format)
{
char **lv[] = { system, event, prefix, addr, format };
- char **rv[] = { &dynevent->system, &dynevent->event, &dynevent->prefix,
- &dynevent->address, &dynevent->format };
+ char **rv[] = { NULL, NULL, NULL, NULL, NULL };
int i;
if (!dynevent)
return TRACEFS_DYNEVENT_UNKNOWN;
+ rv[0] = &dynevent->system;
+ rv[1] = &dynevent->event;
+ rv[2] = &dynevent->prefix;
+ rv[3] = &dynevent->address;
+ rv[4] = &dynevent->format;
+
for (i = 0; i < ARRAY_SIZE(lv); i++) {
if (lv[i]) {
if (*rv[i]) {
--
2.35.1.574.g5d30c73bfb-goog
next prev parent reply other threads:[~2022-02-24 23:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 23:48 [PATCH 1/3] libtracefs: Fix spelling in test name Ian Rogers
2022-02-24 23:48 ` [PATCH 2/3] libtracefs: Avoid null access Ian Rogers
2022-02-24 23:48 ` Ian Rogers [this message]
2022-02-24 23:55 ` [PATCH 3/3] libtracefs: Move initialization below a null test Steven Rostedt
2022-02-25 0:09 ` Ian Rogers
2022-02-25 0:20 ` Steven Rostedt
2022-02-25 0:21 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224234823.1190425-3-irogers@google.com \
--to=irogers@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).