From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: sebastian@breakpoint.cc, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 4/5] trace-cmd: Add context to compression hooks
Date: Wed, 2 Mar 2022 20:10:04 -0500 [thread overview]
Message-ID: <20220302201004.4c19f84f@gandalf.local.home> (raw)
In-Reply-To: <20220302045131.387658-5-tz.stoyanov@gmail.com>
On Wed, 2 Mar 2022 06:51:30 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> @@ -453,6 +460,8 @@ struct tracecmd_compression *tracecmd_compress_alloc(const char *name, const cha
> void tracecmd_compress_destroy(struct tracecmd_compression *handle)
> {
> tracecmd_compress_reset(handle);
> + if (handle->proto->free_context)
> + handle->proto->free_context(handle->context);
> free(handle);
> }
>
I segfaulted here with:
# trace-cmd restore -c -o /tmp/head
Need to test handle is NULL or not.
Perhaps even just exit normally at the start?
if (!handle)
return;
Which makes it not crash.
-- Steve
next prev parent reply other threads:[~2022-03-03 1:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 4:51 [PATCH 0/5] trace-cmd: Improvements in compression logic Tzvetomir Stoyanov (VMware)
2022-03-02 4:51 ` [PATCH 1/5] trace-cmd: Use a structure to describe a compression protocol Tzvetomir Stoyanov (VMware)
2022-03-02 7:03 ` Sebastian Andrzej Siewior
2022-03-02 4:51 ` [PATCH 2/5] trace-cmd: Make internal compression hooks more generic Tzvetomir Stoyanov (VMware)
2022-03-02 7:08 ` Sebastian Andrzej Siewior
2022-03-02 4:51 ` [PATCH 3/5] trace-cmd: Use errno from zlib, if available Tzvetomir Stoyanov (VMware)
2022-03-02 7:15 ` Sebastian Andrzej Siewior
2022-03-02 15:52 ` Steven Rostedt
2022-03-03 7:09 ` Sebastian Andrzej Siewior
2022-03-02 4:51 ` [PATCH 4/5] trace-cmd: Add context to compression hooks Tzvetomir Stoyanov (VMware)
2022-03-02 7:13 ` Sebastian Andrzej Siewior
2022-03-03 1:10 ` Steven Rostedt [this message]
2022-03-03 16:33 ` Tzvetomir Stoyanov
2022-03-02 4:51 ` [PATCH 5/5] trace-cmd: Use context hooks in zstd Tzvetomir Stoyanov (VMware)
2022-03-02 7:13 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302201004.4c19f84f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).