From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: sebastian@breakpoint.cc, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] trace-cmd: Use a structure to describe a compression protocol
Date: Fri, 4 Mar 2022 13:18:59 -0500 [thread overview]
Message-ID: <20220304131859.308694df@gandalf.local.home> (raw)
In-Reply-To: <20220304055658.440904-2-tz.stoyanov@gmail.com>
On Fri, 4 Mar 2022 07:56:54 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> Changed the tracecmd_compress_proto_register() function to use a
> structure instead of list of arguments to describe new compression
> protocol. That approach is more flexible and allows to extend the API in
> the future without changing the already implemented protocols.
>
> Suggested-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
> ---
>
Hi Tzvetomir,
Just an FYI. Sebastian gave an "Acked-by" to these patches previously. It
should be added to the follow up patches if the patches haven't changed.
And you can even keep them if the patch changed slightly (like to fix the
crash I reported).
Otherwise, the Acked-by's will likely be dropped. If I didn't notice this,
they would have been.
So, unless the patch changes in logic, all new versions should contain
Acked/Reviewed-by tags that you have received from previous versions.
https://lore.kernel.org/all/Yh8Wq4KAGJ6WtqKc@breakpoint.cc/
Just so you know for future patches.
-- Steve
next prev parent reply other threads:[~2022-03-04 18:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 5:56 [PATCH v2 0/5] trace-cmd: Improvements in compression logic Tzvetomir Stoyanov (VMware)
2022-03-04 5:56 ` [PATCH v2 1/5] trace-cmd: Use a structure to describe a compression protocol Tzvetomir Stoyanov (VMware)
2022-03-04 18:18 ` Steven Rostedt [this message]
2022-03-04 5:56 ` [PATCH v2 2/5] trace-cmd: Make internal compression hooks more generic Tzvetomir Stoyanov (VMware)
2022-03-04 5:56 ` [PATCH v2 3/5] trace-cmd: Use errno from zlib, if available Tzvetomir Stoyanov (VMware)
2022-03-04 5:56 ` [PATCH v2 4/5] trace-cmd: Add context to compression hooks Tzvetomir Stoyanov (VMware)
2022-03-04 5:56 ` [PATCH v2 5/5] trace-cmd: Use context hooks in zstd Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304131859.308694df@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).