linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] trace-cmd library: Fix off by one in tracecmd_read_cpu_first()
Date: Mon, 14 Mar 2022 13:02:01 -0400	[thread overview]
Message-ID: <20220314130201.6356821a@gandalf.local.home> (raw)

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The check in tracecmd_read_cpu_first() checks:

  if (cpus > handle->cpus)

When that should be >=, as cpus is the number of CPUs in the array, and
not the last CPU.

This wasn't noticed in tests because it only warns and does not crash.

Fixes: 3869d1529a99 ("trace-cmd library: Do not read CPU greater than CPUs registered")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 lib/trace-cmd/trace-input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index 313534d09e86..643dd807c575 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -2028,7 +2028,7 @@ tracecmd_read_cpu_first(struct tracecmd_input *handle, int cpu)
 	unsigned long long page_offset;
 	int ret;
 
-	if (cpu > handle->cpus)
+	if (cpu >= handle->cpus)
 		return NULL;
 
 	page_offset = calc_page_offset(handle, handle->cpu_data[cpu].file_offset);
-- 
2.35.1


                 reply	other threads:[~2022-03-14 17:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220314130201.6356821a@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).