linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] trace-cmd library: Fix off by one in tracecmd_read_cpu_first()
@ 2022-03-14 17:02 Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2022-03-14 17:02 UTC (permalink / raw)
  To: Linux Trace Devel

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The check in tracecmd_read_cpu_first() checks:

  if (cpus > handle->cpus)

When that should be >=, as cpus is the number of CPUs in the array, and
not the last CPU.

This wasn't noticed in tests because it only warns and does not crash.

Fixes: 3869d1529a99 ("trace-cmd library: Do not read CPU greater than CPUs registered")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 lib/trace-cmd/trace-input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index 313534d09e86..643dd807c575 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -2028,7 +2028,7 @@ tracecmd_read_cpu_first(struct tracecmd_input *handle, int cpu)
 	unsigned long long page_offset;
 	int ret;
 
-	if (cpu > handle->cpus)
+	if (cpu >= handle->cpus)
 		return NULL;
 
 	page_offset = calc_page_offset(handle, handle->cpu_data[cpu].file_offset);
-- 
2.35.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-03-14 17:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-14 17:02 [PATCH] trace-cmd library: Fix off by one in tracecmd_read_cpu_first() Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).