From: Joel Fernandes <joel@joelfernandes.org>
To: linux-trace-devel@vger.kernel.org
Cc: vineethrp@google.com, rostedt@google.com,
Joel Fernandes <joel@joelfernandes.org>
Subject: [PATCH] trace-cmd: Try alternate path for message cache
Date: Tue, 29 Mar 2022 19:18:01 +0000 [thread overview]
Message-ID: <20220329191801.429691-1-joel@joelfernandes.org> (raw)
For some systems like Android, /tmp/ does not exist. Use the /data/
directory for message cache.
With this, host guest tracing works on Android VM running on ChromeOS.
Cc: Vineeth Pillai <vineethrp@google.com>
Signed-off-by: Joel Fernandes <joel@joelfernandes.org>
---
lib/trace-cmd/include/private/trace-cmd-private.h | 3 ++-
lib/trace-cmd/trace-msg.c | 10 ++++++++--
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/lib/trace-cmd/include/private/trace-cmd-private.h b/lib/trace-cmd/include/private/trace-cmd-private.h
index 6934376..492ad9c 100644
--- a/lib/trace-cmd/include/private/trace-cmd-private.h
+++ b/lib/trace-cmd/include/private/trace-cmd-private.h
@@ -377,7 +377,8 @@ enum tracecmd_msg_flags {
};
/* for both client and server */
-#define MSG_CACHE_FILE "/tmp/trace_msg_cacheXXXXXX"
+#define MSG_CACHE_FILE "/tmp/trace_msg_cacheXXXXXX"
+#define MSG_CACHE_FILE2 "/data/trace_msg_cacheXXXXXX"
struct tracecmd_msg_handle {
int fd;
short cpu_count;
diff --git a/lib/trace-cmd/trace-msg.c b/lib/trace-cmd/trace-msg.c
index 03b853e..91dac77 100644
--- a/lib/trace-cmd/trace-msg.c
+++ b/lib/trace-cmd/trace-msg.c
@@ -595,8 +595,14 @@ int tracecmd_msg_handle_cache(struct tracecmd_msg_handle *msg_handle)
if (msg_handle->cfd < 0) {
strcpy(msg_handle->cfile, MSG_CACHE_FILE);
msg_handle->cfd = mkstemp(msg_handle->cfile);
- if (msg_handle->cfd < 0)
- return -1;
+ if (msg_handle->cfd < 0) {
+ /* Try an alternate path. */
+ strcpy(msg_handle->cfile, MSG_CACHE_FILE2);
+ msg_handle->cfd = mkstemp(msg_handle->cfile);
+ if (msg_handle->cfd < 0) {
+ return -1;
+ }
+ }
unlink(msg_handle->cfile);
}
msg_handle->cache = true;
--
2.35.1.1021.g381101b075-goog
next reply other threads:[~2022-03-29 19:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 19:18 Joel Fernandes [this message]
2022-04-01 19:37 ` [PATCH] trace-cmd: Try alternate path for message cache Steven Rostedt
[not found] ` <CAEXW_YQxPgaKOMhDy8kVdaT9esvY8ctP1Mfw3RZXwkJkTYhh0w@mail.gmail.com>
2022-04-01 23:06 ` Steven Rostedt
2022-04-03 14:56 ` Joel Fernandes
2022-04-03 15:24 ` Joel Fernandes
2022-04-03 17:35 ` Steven Rostedt
2022-04-04 4:41 ` Tzvetomir Stoyanov
2022-04-04 5:02 ` Tzvetomir Stoyanov
2022-04-04 13:21 ` Joel Fernandes
2022-04-04 13:48 ` Tzvetomir Stoyanov
2022-04-04 14:11 ` Joel Fernandes
2022-04-04 14:35 ` Steven Rostedt
2022-04-04 14:48 ` Tzvetomir Stoyanov
2022-04-04 15:04 ` Steven Rostedt
2022-04-04 15:15 ` Tzvetomir Stoyanov
2022-04-04 15:27 ` Steven Rostedt
2022-04-04 15:32 ` Steven Rostedt
2022-04-04 15:40 ` Joel Fernandes
2022-04-04 15:41 ` Joel Fernandes
2022-04-04 15:47 ` Steven Rostedt
2022-04-04 17:20 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329191801.429691-1-joel@joelfernandes.org \
--to=joel@joelfernandes.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@google.com \
--cc=vineethrp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).