[PATCH 1/2] rtla: Don't overwrite existing directory mode

[PATCH 1/2] rtla: Don't overwrite existing directory mode

[John Kacur]

The mode on /usr/bin is often 555 these days,
but make install on rtla overwrites this with 755

Fix this by preserving the current directory if it exists.

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 tools/tracing/rtla/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/tracing/rtla/Makefile b/tools/tracing/rtla/Makefile
index 11fb417abb42..5a3226e436ef 100644
--- a/tools/tracing/rtla/Makefile
+++ b/tools/tracing/rtla/Makefile
@@ -23,6 +23,7 @@ $(call allow-override,LD_SO_CONF_PATH,/etc/ld.so.conf.d/)
 $(call allow-override,LDCONFIG,ldconfig)
 
 INSTALL	=	install
+MKDIR	=	mkdir
 FOPTS	:=	-flto=auto -ffat-lto-objects -fexceptions -fstack-protector-strong \
 		-fasynchronous-unwind-tables -fstack-clash-protection
 WOPTS	:= 	-Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -Wno-maybe-uninitialized
@@ -68,7 +69,7 @@ static: $(OBJ)
 
 .PHONY: install
 install: doc_install
-	$(INSTALL) -d -m 755 $(DESTDIR)$(BINDIR)
+	$(MKDIR) -p $(DESTDIR)$(BINDIR)
 	$(INSTALL) rtla -m 755 $(DESTDIR)$(BINDIR)
 	$(STRIP) $(DESTDIR)$(BINDIR)/rtla
 	@test ! -f $(DESTDIR)$(BINDIR)/osnoise || rm $(DESTDIR)$(BINDIR)/osnoise
-- 
2.31.1

[PATCH 2/2] rtla: Minor fix to grammar in README.txt

[John Kacur]

"The rtla" doesn't make sense, change it to "The rtla tool"
This is better than removing the word "The" since some packaging tools
need the description to start with a capital letter.

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 tools/tracing/rtla/README.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tracing/rtla/README.txt b/tools/tracing/rtla/README.txt
index 6c88446f7e74..3b809eeff5f9 100644
--- a/tools/tracing/rtla/README.txt
+++ b/tools/tracing/rtla/README.txt
@@ -1,6 +1,6 @@
 RTLA: Real-Time Linux Analysis tools
 
-The rtla is a meta-tool that includes a set of commands that
+The rtla tool is a meta-tool that includes a set of commands that
 aims to analyze the real-time properties of Linux. But, instead of
 testing Linux as a black box, rtla leverages kernel tracing
 capabilities to provide precise information about the properties
-- 
2.31.1

Re: [PATCH 2/2] rtla: Minor fix to grammar in README.txt

[Daniel Bristot de Oliveira]

On 4/2/22 06:39, John Kacur wrote:
> "The rtla" doesn't make sense, change it to "The rtla tool"
> This is better than removing the word "The" since some packaging tools
> need the description to start with a capital letter.
> 
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
>  tools/tracing/rtla/README.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/tracing/rtla/README.txt b/tools/tracing/rtla/README.txt
> index 6c88446f7e74..3b809eeff5f9 100644
> --- a/tools/tracing/rtla/README.txt
> +++ b/tools/tracing/rtla/README.txt
> @@ -1,6 +1,6 @@
>  RTLA: Real-Time Linux Analysis tools
>  
> -The rtla is a meta-tool that includes a set of commands that
> +The rtla tool is a meta-tool that includes a set of commands that

I do not like bike-shedding but 'the rtla tool is a meta-tool" sounds repetitive.

Does:

The rtla meta-tool includes a set of commands...

sound good for you?

-- Daniel

Re: [PATCH 2/2] rtla: Minor fix to grammar in README.txt

[John Kacur]

On Fri, 8 Apr 2022, Daniel Bristot de Oliveira wrote:

> On 4/2/22 06:39, John Kacur wrote:
> > "The rtla" doesn't make sense, change it to "The rtla tool"
> > This is better than removing the word "The" since some packaging tools
> > need the description to start with a capital letter.
> > 
> > Signed-off-by: John Kacur <jkacur@redhat.com>
> > ---
> >  tools/tracing/rtla/README.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/tracing/rtla/README.txt b/tools/tracing/rtla/README.txt
> > index 6c88446f7e74..3b809eeff5f9 100644
> > --- a/tools/tracing/rtla/README.txt
> > +++ b/tools/tracing/rtla/README.txt
> > @@ -1,6 +1,6 @@
> >  RTLA: Real-Time Linux Analysis tools
> >  
> > -The rtla is a meta-tool that includes a set of commands that
> > +The rtla tool is a meta-tool that includes a set of commands that
> 
> I do not like bike-shedding but 'the rtla tool is a meta-tool" sounds repetitive.
> 
> Does:
> 
> The rtla meta-tool includes a set of commands...
> 
> sound good for you?
> 
> -- Daniel
> 
> 

Perfect

Re: [PATCH 2/2] rtla: Minor fix to grammar in README.txt

[Daniel Bristot de Oliveira]

>>> -The rtla is a meta-tool that includes a set of commands that
>>> +The rtla tool is a meta-tool that includes a set of commands that
>> I do not like bike-shedding but 'the rtla tool is a meta-tool" sounds repetitive.
>>
>> Does:
>>
>> The rtla meta-tool includes a set of commands...
>>
>> sound good for you?
>>
>> -- Daniel
>>
>>
> Perfect
> 

Would you mind re-sending this patch?

You will also need to adjust the paragraph alignment as the first line is
shorter now ...
-- Daniel

Re: [PATCH 1/2] rtla: Don't overwrite existing directory mode

[Daniel Bristot de Oliveira]

On 4/2/22 06:39, John Kacur wrote:
> The mode on /usr/bin is often 555 these days,
> but make install on rtla overwrites this with 755
> 
> Fix this by preserving the current directory if it exists.
> 
> Signed-off-by: John Kacur <jkacur@redhat.com>

Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>

Thanks!
-- Daniel