[PATCH 0/3] trace-cruncher: Small fixes

[PATCH 0/3] trace-cruncher: Small fixes

[Tzvetomir Stoyanov (VMware)]

Fixed problems, found by github CI automatic workflow.

Tzvetomir Stoyanov (VMware) (3):
  trace-cruncher: Add define for bool type
  trace-cruncher: Update github workflows
  trace-cruncher: Add object files to gitignore

 .github/workflows/main.yml | 2 +-
 .gitignore                 | 1 +
 src/trace-obj-debug.c      | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.35.1

[PATCH 1/3] trace-cruncher: Add define for bool type

[Tzvetomir Stoyanov (VMware)]

The logic for resolving function name to address uses bool type, which
is defined in stdbool.h header file. Add explicitly include to this
file.

Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
 src/trace-obj-debug.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/trace-obj-debug.c b/src/trace-obj-debug.c
index 0e0e293..3ce3b54 100644
--- a/src/trace-obj-debug.c
+++ b/src/trace-obj-debug.c
@@ -11,6 +11,7 @@
 
 #include <stdlib.h>
 #include <stdio.h>
+#include <stdbool.h>
 #include <string.h>
 #include <limits.h>
 #include <errno.h>
-- 
2.35.1

[PATCH 2/3] trace-cruncher: Update github workflows

[Tzvetomir Stoyanov (VMware)]

Recent commits add functionality for function name to address resolving,
using bfd library. This breaks the github action, used for
trace-cruncher CI, as it does not have bfd development files. Updated
the workflow with bfd development package.

Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
 .github/workflows/main.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index a9520e7..0d72bbf 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -17,7 +17,7 @@ jobs:
       shell: bash
       run: |
         sudo apt-get update
-        sudo apt-get install build-essential git cmake libjson-c-dev -y
+        sudo apt-get install build-essential git cmake libjson-c-dev binutils-dev -y
         sudo apt-get install libpython3-dev cython3 python3-numpy -y
         sudo apt install python3-pip
         sudo pip3 install --system pkgconfig GitPython
-- 
2.35.1

[PATCH 3/3] trace-cruncher: Add object files to gitignore

[Tzvetomir Stoyanov (VMware)]

Object files, produced by the compilation should not be committed.
Updated the .gitignore file with these files.

Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 9fb86e5..2d47632 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@
 *.so
 *.a
+*.o
 .*.d
 *~
 *.pyc
-- 
2.35.1

Re: [PATCH 2/3] trace-cruncher: Update github workflows

[Yordan Karadzhov]

On 3.05.22 г. 9:48 ч., Tzvetomir Stoyanov (VMware) wrote:
> Recent commits add functionality for function name to address resolving,
> using bfd library. This breaks the github action, used for
> trace-cruncher CI, as it does not have bfd development files. Updated
> the workflow with bfd development package.
> 
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
> ---
>   .github/workflows/main.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index a9520e7..0d72bbf 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -17,7 +17,7 @@ jobs:
>         shell: bash
>         run: |
>           sudo apt-get update
> -        sudo apt-get install build-essential git cmake libjson-c-dev -y
> +        sudo apt-get install build-essential git cmake libjson-c-dev binutils-dev -y

This must be added to the install instructions in README as well.
Probably in a separate patch.

Everything else looks good to me.

Reviewed-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>

>           sudo apt-get install libpython3-dev cython3 python3-numpy -y
>           sudo apt install python3-pip
>           sudo pip3 install --system pkgconfig GitPython