From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Wagner <wagi@monom.org>
Cc: linux-trace-devel@vger.kernel.org, Daniel Wagner <dwagner@suse.de>
Subject: Re: [PATCH] tracefs: Set visibility of parser symbols as 'internal'
Date: Wed, 15 Jun 2022 18:52:57 -0400 [thread overview]
Message-ID: <20220615185257.6d35b5ba@gandalf.local.home> (raw)
In-Reply-To: <20220607091215.24447-1-wagi@monom.org>
On Tue, 7 Jun 2022 11:12:15 +0200
Daniel Wagner <wagi@monom.org> wrote:
> From: Daniel Wagner <dwagner@suse.de>
>
> Two declarations of an object with 'hidden' linkage refer to
> the same object if they are in the same shared object.
>
> Internal visibility is like hidden visibility, but with
> additional processor specific semantics. Unless otherwise specified by
> the psABI, GCC defines internal visibility to mean that a function is
> never called from another module.
>
> It was observed that an 32bit linking against libtracefs failed
> because the parser symbols were missing. As the parser symbols are
> supposed to be used only inside the library, mark them as internal.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
Applied. Thanks Daniel!
-- Steve
prev parent reply other threads:[~2022-06-15 22:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 9:12 [PATCH] tracefs: Set visibility of parser symbols as 'internal' Daniel Wagner
2022-06-15 22:52 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615185257.6d35b5ba@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dwagner@suse.de \
--cc=linux-trace-devel@vger.kernel.org \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).