From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Cc: Chuck Lever III <chuck.lever@oracle.com>
Subject: [PATCH] libtraceevent: Warn when kallsyms exits due to parsing error
Date: Tue, 28 Jun 2022 11:21:31 -0400 [thread overview]
Message-ID: <20220628112131.3f306e97@gandalf.local.home> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
If the kallsyms has a corrupted line, it will exit the parsing. This can
be confusing to users that expect to see function address converted into
names.
Add a tep_warning() when this happens. At least the library will warn
about it (although trace-cmd requires --verbose to see it).
Link: https://lore.kernel.org/all/355D2478-33D3-4046-8422-E512F42C51BC@oracle.com/
Reported-by: Chuck Lever III <chuck.lever@oracle.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
src/event-parse.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/event-parse.c b/src/event-parse.c
index 4bbf29727e9f..823333a3bde4 100644
--- a/src/event-parse.c
+++ b/src/event-parse.c
@@ -739,8 +739,11 @@ int tep_parse_kallsyms(struct tep_handle *tep, const char *kallsyms)
if (errno)
goto out;
- if (n != 2 || !func_end)
+ if (n != 2 || !func_end) {
+ tep_warning("Failed to parse kallsyms n=%d func_end=%d",
+ n, func_end);
goto out;
+ }
func = line + func_start;
/*
--
2.35.1
reply other threads:[~2022-06-28 15:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628112131.3f306e97@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=chuck.lever@oracle.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).