From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs: Set the number of CPUs in tracefs_local_events_system()
Date: Sat, 23 Jul 2022 10:22:32 -0400 [thread overview]
Message-ID: <20220723102232.1ba19aa6@rorschach.local.home> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
When tracefs_local_events() (which also uses tracefs_local_events_system())
is called, it does not set the CPU count for the tep handler. It should do
so, so make that happen.
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
This is added on top of:
https://lore.kernel.org/all/20220722142803.24919c8a@gandalf.local.home/
src/tracefs-events.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/src/tracefs-events.c b/src/tracefs-events.c
index 86395101c96a..9dbeeac938b4 100644
--- a/src/tracefs-events.c
+++ b/src/tracefs-events.c
@@ -945,6 +945,33 @@ out:
return ret;
}
+static void set_tep_cpus(const char *tracing_dir, struct tep_handle *tep)
+{
+ struct stat st;
+ char path[PATH_MAX];
+ int cpus = sysconf(_SC_NPROCESSORS_CONF);
+ int max_cpu = 0;
+ int ret;
+ int i;
+
+ if (!tracing_dir)
+ tracing_dir = tracefs_tracing_dir();
+
+ for (i = 0; !cpus || i < cpus; i++) {
+ snprintf(path, PATH_MAX, "%s/per_cpu/cpu%d", tracing_dir, i);
+ ret = stat(path, &st);
+ if (!ret && S_ISDIR(st.st_mode))
+ max_cpu = i + 1;
+ else if (i >= cpus)
+ break;
+ }
+
+ if (!max_cpu)
+ max_cpu = cpus;
+
+ tep_set_cpus(tep, max_cpu);
+}
+
/**
* tracefs_local_events_system - create a tep from the events of the specified subsystem.
*
@@ -969,6 +996,8 @@ struct tep_handle *tracefs_local_events_system(const char *tracing_dir,
tep = NULL;
}
+ set_tep_cpus(tracing_dir, tep);
+
/* Set the long size for this tep handle */
tep_set_long_size(tep, tep_get_header_page_size(tep));
--
2.35.1
reply other threads:[~2022-07-23 14:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220723102232.1ba19aa6@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).