* [PATCH] libtracefs: allow pthread inclusion overrideable in Makefile
@ 2022-08-20 2:02 John 'Warthog9' Hawley (VMware)
2022-09-08 23:30 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: John 'Warthog9' Hawley (VMware) @ 2022-08-20 2:02 UTC (permalink / raw)
To: linux-trace-devel; +Cc: rostedt
clang fails if you attempt to inclued -lpthread in the linking phase for
certain versions of clang (newer seems to be happier with it). This
should allow for -lpthread to be overridden on the builds where it's
causing problems
Signed-off-by: John 'Warthog9' Hawley (VMware) <warthog9@eaglescrag.net>
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index aa659b4..1d25c14 100644
--- a/Makefile
+++ b/Makefile
@@ -132,7 +132,8 @@ LIBTRACEFS_SHARED_VERSION = $(bdir)/libtracefs.so.$(TFS_VERSION)
PKG_CONFIG_SOURCE_FILE = libtracefs.pc
PKG_CONFIG_FILE := $(addprefix $(obj)/,$(PKG_CONFIG_SOURCE_FILE))
-LIBS = $(LIBTRACEEVENT_LIBS) -lpthread
+LPTHREAD ?= -lpthread
+LIBS = $(LIBTRACEEVENT_LIBS) $(LPTHREAD)
export LIBS
export LIBTRACEFS_STATIC LIBTRACEFS_SHARED
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libtracefs: allow pthread inclusion overrideable in Makefile
2022-08-20 2:02 [PATCH] libtracefs: allow pthread inclusion overrideable in Makefile John 'Warthog9' Hawley (VMware)
@ 2022-09-08 23:30 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2022-09-08 23:30 UTC (permalink / raw)
To: John 'Warthog9' Hawley (VMware); +Cc: linux-trace-devel
On Fri, 19 Aug 2022 19:02:55 -0700
"John 'Warthog9' Hawley (VMware)" <warthog9@eaglescrag.net> wrote:
> clang fails if you attempt to inclued -lpthread in the linking phase for
> certain versions of clang (newer seems to be happier with it). This
> should allow for -lpthread to be overridden on the builds where it's
> causing problems
>
> Signed-off-by: John 'Warthog9' Hawley (VMware) <warthog9@eaglescrag.net>
> ---
Applied. Thanks John!
-- Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-08 23:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-20 2:02 [PATCH] libtracefs: allow pthread inclusion overrideable in Makefile John 'Warthog9' Hawley (VMware)
2022-09-08 23:30 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).