From: Steven Rostedt <rostedt@goodmis.org>
To: Zebediah Figura <zfigura@codeweavers.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] tracecmd extract: Allow using --compression.
Date: Wed, 21 Sep 2022 21:49:41 -0400 [thread overview]
Message-ID: <20220921214941.0d297d5d@gandalf.local.home> (raw)
In-Reply-To: <20220901205638.3247090-1-zfigura@codeweavers.com>
On Thu, 1 Sep 2022 15:56:38 -0500
Zebediah Figura <zfigura@codeweavers.com> wrote:
> From: Zeb Figura <zfigura@codeweavers.com>
>
> This is already supported and works as expected; allow the option to be
> specified.
Hi Zeb,
I'd love to accept this patch, but I need you to add your "Signed-off-by"
tag.
See https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tree/DCO
You can either resend the patch, or reply with it here.
Thanks!
-- Steve
> ---
> tracecmd/trace-record.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
> index 3442e9b..70fb187 100644
> --- a/tracecmd/trace-record.c
> +++ b/tracecmd/trace-record.c
> @@ -6648,7 +6648,6 @@ static void parse_record_options(int argc,
> case OPT_compression:
> cmd_check_die(ctx, CMD_start, *(argv+1), "--compression");
> cmd_check_die(ctx, CMD_set, *(argv+1), "--compression");
> - cmd_check_die(ctx, CMD_extract, *(argv+1), "--compression");
> cmd_check_die(ctx, CMD_stream, *(argv+1), "--compression");
> cmd_check_die(ctx, CMD_profile, *(argv+1), "--compression");
> if (strcmp(optarg, "any") && strcmp(optarg, "none") &&
next prev parent reply other threads:[~2022-09-22 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 20:56 [PATCH] tracecmd extract: Allow using --compression Zebediah Figura
2022-09-22 1:49 ` Steven Rostedt [this message]
2022-09-22 2:20 ` Zebediah Figura
2022-09-22 12:39 ` Steven Rostedt
2022-09-22 15:26 ` Zebediah Figura
2022-09-22 15:40 ` Steven Rostedt
2022-09-22 15:25 ` Zebediah Figura
2022-09-22 15:27 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921214941.0d297d5d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=zfigura@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).