From: Steven Rostedt <rostedt@goodmis.org>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: mhiramat@kernel.org, linux-trace-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Track event ref in tracefs enable/disable
Date: Wed, 12 Oct 2022 18:26:39 -0400 [thread overview]
Message-ID: <20221012182639.5a607add@rorschach.local.home> (raw)
In-Reply-To: <20221012215717.10492-1-beaub@linux.microsoft.com>
On Wed, 12 Oct 2022 14:57:17 -0700
Beau Belgrave <beaub@linux.microsoft.com> wrote:
> When events are enabled via the "enable" file within tracefs there is no
> get or put ref. Add these to ensure modules and dynamic events do not
> unload while the event is enabled via tracefs.
Why is this an issue?
The events are only called from the module code, and when the module is
unloaded, they are no longer called. Why keep the module from unloading
when enabled?
-- Steve
next prev parent reply other threads:[~2022-10-12 22:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 21:57 [PATCH] tracing: Track event ref in tracefs enable/disable Beau Belgrave
2022-10-12 22:26 ` Steven Rostedt [this message]
2022-10-13 0:19 ` Beau Belgrave
2022-10-13 7:58 ` Steven Rostedt
2022-10-13 16:39 ` Beau Belgrave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221012182639.5a607add@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=beaub@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox