From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/2] rv/dot2c: Make automaton definition static
Date: Tue, 18 Oct 2022 18:25:53 -0400 [thread overview]
Message-ID: <20221018182553.06f13a50@gandalf.local.home> (raw)
In-Reply-To: <ffbb92010f643307766c9307fd42f416e5b85fa0.1661266564.git.bristot@kernel.org>
On Tue, 23 Aug 2022 17:20:28 +0200
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
> Monitor's automata definition is only used locally, so make dot2c generate
> a static definition.
>
> Link: https://lore.kernel.org/all/202208210332.gtHXje45-lkp@intel.com
> Link: https://lore.kernel.org/all/202208210358.6HH3OrVs-lkp@intel.com
>
Somehow this fell through the cracks.
Daniel, is there any reason I shouldn't pull this in now?
-- Steve
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Fixes: e3c9fc78f096 ("tools/rv: Add dot2c")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org>
> ---
> tools/verification/dot2/dot2c.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/verification/dot2/dot2c.py b/tools/verification/dot2/dot2c.py
> index fa73353f7e56..be8a364a469b 100644
> --- a/tools/verification/dot2/dot2c.py
> +++ b/tools/verification/dot2/dot2c.py
> @@ -111,7 +111,7 @@ class Dot2c(Automata):
>
> def format_aut_init_header(self):
> buff = []
> - buff.append("struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def))
> + buff.append("static struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def))
> return buff
>
> def __get_string_vector_per_line_content(self, buff):
next prev parent reply other threads:[~2022-10-18 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 15:20 [PATCH 1/2] rv/dot2c: Make automaton definition static Daniel Bristot de Oliveira
2022-08-23 15:20 ` [PATCH 2/2] rv/monitors: Make monitor's automata " Daniel Bristot de Oliveira
2022-10-18 22:25 ` Steven Rostedt [this message]
2022-10-18 22:28 ` [PATCH 1/2] rv/dot2c: Make automaton " Steven Rostedt
2022-10-19 13:15 ` Daniel Bristot de Oliveira
2022-10-20 20:55 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018182553.06f13a50@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).