From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs: Fixe tracefs_iterate_stop() when instance is used
Date: Mon, 14 Nov 2022 23:56:51 -0500 [thread overview]
Message-ID: <20221114235651.7c1b98d7@gandalf.local.home> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
There was a cut and paste error where tracefs_iterate_stop() was using the
instance->pipe_keep_going instead of the instance->iterate_keep_going and
it caused the tracefs_iterate_stop() to not stop the iterator on
instances.
Fixes: ffcc062c6352d ("libtracefs: Add tracefs_iterate_stop()")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
src/tracefs-events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tracefs-events.c b/src/tracefs-events.c
index e92663656688..daa81c07ecb5 100644
--- a/src/tracefs-events.c
+++ b/src/tracefs-events.c
@@ -418,7 +418,7 @@ int tracefs_iterate_raw_events(struct tep_handle *tep,
int, void *),
void *callback_context)
{
- bool *keep_going = instance ? &instance->pipe_keep_going :
+ bool *keep_going = instance ? &instance->iterate_keep_going :
&top_iterate_keep_going;
struct cpu_iterate *all_cpus;
int count = 0;
--
2.35.1
reply other threads:[~2022-11-15 4:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114235651.7c1b98d7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).