From: Bean Huo <beanhuo@iokpp.de>
To: linux-trace-devel@vger.kernel.org, rostedt@goodmis.org,
tz.stoyanov@gmail.com
Cc: Bean Huo <beanhuo@micron.com>
Subject: [PATCH] libtracefs: Fix wrong return value in tracefs_tracing_dir_is_mounted()
Date: Mon, 28 Nov 2022 14:21:06 +0100 [thread overview]
Message-ID: <20221128132106.291101-1-beanhuo@iokpp.de> (raw)
From: Bean Huo <beanhuo@micron.com>
If it eventually mounts successfully, it should return 1 instead of
0, otherwise it will make the caller's verification logic more complicated
Signed-off-by: Bean Huo <beanhuo@micron.com>
---
src/tracefs-utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tracefs-utils.c b/src/tracefs-utils.c
index 777912e..5d6e977 100644
--- a/src/tracefs-utils.c
+++ b/src/tracefs-utils.c
@@ -188,7 +188,7 @@ int tracefs_tracing_dir_is_mounted(bool mount, const char **path)
return -1;
if (path)
*path = dir;
- return 0;
+ return 1;
}
/**
--
2.25.1
next reply other threads:[~2022-11-28 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 13:21 Bean Huo [this message]
2022-11-28 15:24 ` [PATCH] libtracefs: Fix wrong return value in tracefs_tracing_dir_is_mounted() Steven Rostedt
2022-11-28 15:41 ` Bean Huo
2022-11-28 16:29 ` Bean Huo
2022-11-28 18:37 ` Steven Rostedt
2022-12-06 21:13 ` Steven Rostedt
2022-12-08 12:05 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128132106.291101-1-beanhuo@iokpp.de \
--to=beanhuo@iokpp.de \
--cc=beanhuo@micron.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).