From: Steven Rostedt <rostedt@goodmis.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-trace-devel@vger.kernel.org,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Clark Williams <williams@redhat.com>,
Douglas RAILLARD <douglas.raillard@arm.com>
Subject: Re: [PATCH v2 1/2] libtraceevent: Add boiler-plate code for cpumask types
Date: Tue, 6 Dec 2022 15:08:13 -0500 [thread overview]
Message-ID: <20221206150813.35b5aa48@gandalf.local.home> (raw)
In-Reply-To: <20221116144154.3662923-2-vschneid@redhat.com>
On Wed, 16 Nov 2022 14:41:53 +0000
Valentin Schneider <vschneid@redhat.com> wrote:
> diff --git a/include/traceevent/event-parse.h b/include/traceevent/event-parse.h
> index f749cc2..2bb0f3e 100644
> --- a/include/traceevent/event-parse.h
> +++ b/include/traceevent/event-parse.h
> @@ -242,6 +242,7 @@ enum tep_print_arg_type {
> TEP_PRINT_OP,
> TEP_PRINT_FUNC,
> TEP_PRINT_BITMASK,
> + TEP_PRINT_CPUMASK,
> TEP_PRINT_DYNAMIC_ARRAY_LEN,
> TEP_PRINT_HEX_STR,
> };
I was about to apply this when I realized that this enum is exposed to
applications. Any new enum must go at the end.
-- Steve
next prev parent reply other threads:[~2022-12-06 20:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 14:41 [PATCH v2 0/2] libtraceevent: Handling cpumask event fields Valentin Schneider
2022-11-16 14:41 ` [PATCH v2 1/2] libtraceevent: Add boiler-plate code for cpumask types Valentin Schneider
2022-12-06 20:08 ` Steven Rostedt [this message]
2022-12-07 9:55 ` Valentin Schneider
2022-11-16 14:46 ` [PATCH v2 2/2] libtraceevent: Pretty-print cpumask fields as a cpulist Valentin Schneider
2022-12-06 20:32 ` Steven Rostedt
2022-12-07 9:55 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206150813.35b5aa48@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@redhat.com \
--cc=douglas.raillard@arm.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=vschneid@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).