From: Steven Rostedt <rostedt@goodmis.org>
To: Mike Frysinger <vapier@google.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Ross Zwisler <zwisler@google.com>
Subject: Re: [PATCH] libtraceevent: Have 32 bit compile with -D_FILE_OFFSET_BITS=64
Date: Tue, 20 Dec 2022 16:35:11 -0500 [thread overview]
Message-ID: <20221220163511.3acc06ff@gandalf.local.home> (raw)
In-Reply-To: <CAAbOScks--ApY2b+4voM73PSx5dL1rLU7R3=8Bs66HDKN-6LMA@mail.gmail.com>
On Tue, 20 Dec 2022 16:29:49 -0500
Mike Frysinger <vapier@google.com> wrote:
> i am certainly by no means an expert in this codebase. from glancing
> at it, the impact is that people won't be able to load any plugins
> right ? that's where stat() & readdir() appear to be used (the dirent
> returned by readdir has both ino_t & off_t in it).
If the plugins are not added, it will just not format some of the trace
events properly.
The plugins are used for better pretty printing the data, otherwise it just
prints out the field contents in their raw formats.
-- Steve
prev parent reply other threads:[~2022-12-20 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 22:34 [PATCH] libtraceevent: Have 32 bit compile with -D_FILE_OFFSET_BITS=64 Steven Rostedt
2022-12-20 19:36 ` Mike Frysinger
2022-12-20 21:00 ` Steven Rostedt
2022-12-20 21:29 ` Mike Frysinger
2022-12-20 21:35 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220163511.3acc06ff@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=vapier@google.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).