linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] libtracecmd: Add initial support for meson
Date: Sat, 24 Dec 2022 11:32:52 +0100	[thread overview]
Message-ID: <20221224103252.zwrnfq65dcuigoek@carbon.lan> (raw)
In-Reply-To: <20221223142543.3c5029a3@gandalf.local.home>

On Fri, Dec 23, 2022 at 02:25:43PM -0500, Steven Rostedt wrote:
> On Fri, 23 Dec 2022 11:15:01 +0100
> Daniel Wagner <dwagner@suse.de> wrote:
> 
> > +++ b/lib/meson.build
> > @@ -0,0 +1,109 @@
> > +# SPDX-License-Identifier: LGPL-2.1
> > +#
> > +# Copyright (c) 2022 Daniel Wagner, SUSE LLC
> > +
> > +project(
> > +    'libtrace-cmd', ['c'],
> > +    meson_version: '>= 0.50.0',
> > +    license: 'GPL-2.0',
> > +    version: '1.3.0',
> > +    default_options: [
> > +      'c_std=gnu99',
> > +      'buildtype=release',
> 
> The default buildtype should be debug. If someone downloads the source,
> they are probably going to debug it. I found this annoying when I went to
> use gdb, and there were no symbols present.

Makes sense. I'll update it accordingly.

  reply	other threads:[~2022-12-24 10:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 10:15 [PATCH v2 0/2] Add initial support for meson Daniel Wagner
2022-12-23 10:15 ` [PATCH v2 1/2] libtracecmd: " Daniel Wagner
2022-12-23 19:25   ` Steven Rostedt
2022-12-24 10:32     ` Daniel Wagner [this message]
2022-12-23 10:15 ` [PATCH v2 2/2] trace-cmd: " Daniel Wagner
2022-12-23 16:18   ` Steven Rostedt
2022-12-23 16:24     ` Steven Rostedt
2022-12-24 10:34       ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221224103252.zwrnfq65dcuigoek@carbon.lan \
    --to=dwagner@suse.de \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).