From: Gabriel Krisman Bertazi <krisman@suse.de>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@suse.de>
Subject: [PATCH trace-cmd v2 0/3] trace-cmd filtering
Date: Thu, 30 Mar 2023 15:52:08 -0300 [thread overview]
Message-ID: <20230330185211.5604-1-krisman@suse.de> (raw)
Hi Steve,
This implements my fix to restore single input filtering behavior
(bz217038) and adds support for global filters, as you requested.
On another topic, a current behavior that seems weird in my opinion is
that the following negates the second filter as well.
"trace-cmd -i trace.dat.1 -v -F tp1 -i trace.dat.2 -F tp2"
I'd prefer that -v would apply only to the following -F. It'd allow me
to do:
"trace-cmd -v -F 'mm_page_alloc' -i trace.dat.1 -i trace.dat.2 ... \
-i trace.dat.10 -F 'mm_page_alloc:order==1'"
It obviously breaks the interface, so I didn't implement it here. Would
like to hear your input, though. We could have a new syntax:
"trace-cmd ! -F tp1 -F tp2 ! -F tp3"
Thanks,
Gabriel Krisman Bertazi (3):
trace-cmd report: Ensure filter is applied to single input file
trace-cmd-report: Support global filters
documentation: trace-cmd-report: Document filter scope
.../trace-cmd/trace-cmd-report.1.txt | 8 +++-
tracecmd/trace-read.c | 45 ++++++++++++-------
2 files changed, 34 insertions(+), 19 deletions(-)
--
2.40.0
next reply other threads:[~2023-03-30 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 18:52 Gabriel Krisman Bertazi [this message]
2023-03-30 18:52 ` [PATCH trace-cmd v2 1/3] trace-cmd report: Ensure filter is applied to single input file Gabriel Krisman Bertazi
2023-03-30 18:52 ` [PATCH trace-cmd v2 2/3] trace-cmd-report: Support global filters Gabriel Krisman Bertazi
2023-03-30 18:52 ` [PATCH trace-cmd v2 3/3] documentation: trace-cmd-report: Document filter scope Gabriel Krisman Bertazi
2023-05-06 22:35 ` [PATCH trace-cmd v2 0/3] trace-cmd filtering Gabriel Krisman Bertazi
2023-05-07 1:51 ` Steven Rostedt
2023-05-30 8:20 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330185211.5604-1-krisman@suse.de \
--to=krisman@suse.de \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).