From: Steven Rostedt <rostedt@goodmis.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-trace-devel@vger.kernel.org, cocci@inria.fr
Subject: Re: [PATCH v3] trace-cmd: Check all strdup() return values
Date: Sat, 3 Jun 2023 12:14:00 -0400 [thread overview]
Message-ID: <20230603121400.0706000f@rorschach.local.home> (raw)
In-Reply-To: <8b23bb42-0b20-850f-b155-c407b671fdda@web.de>
On Sat, 3 Jun 2023 13:20:37 +0200
Markus Elfring <Markus.Elfring@web.de> wrote:
> …
> > +++ b/lib/trace-cmd/trace-output.c
> > @@ -230,6 +230,7 @@ void tracecmd_set_out_clock(struct tracecmd_output *handle, const char *clock)
> > if (handle && clock) {
> > free(handle->trace_clock);
> > handle->trace_clock = strdup(clock);
> > + /* TODO: report error if failed to allocate */
> > }
> > }
>
> How will this place be improved?
Bah. This patch is not worth the pain. I'm just going to drop it.
-- Steve
prev parent reply other threads:[~2023-06-03 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 9:44 [PATCH v3] trace-cmd: Check all strdup() return values Steven Rostedt
[not found] ` <8b23bb42-0b20-850f-b155-c407b671fdda@web.de>
2023-06-03 16:14 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230603121400.0706000f@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=Markus.Elfring@web.de \
--cc=cocci@inria.fr \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).